Assorted bug fixes ELUT reader, vis calibration and livetime correction naming #194
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
- Coverage 81.05% 80.97% -0.09%
==========================================
Files 35 35
Lines 2386 2391 +5
==========================================
+ Hits 1934 1936 +2
- Misses 452 455 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes multiple calibration and I/O issues: robust ELUT column handling, correct live-time usage in visibility calibration, and completing the SkyCoord migration in calibrate_visibility. It also updates tests, changelogs, and CI triggers.
- Make ELUT reader resilient to upstream column name changes
- Return corrected live-time from get_livetime_fraction and update consumers/tests
- Update calibrate_visibility to use SkyCoord default and add input validation
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| stixpy/io/readers.py | Detect offset/gain columns by name (case-insensitive) to adapt to upstream changes. |
| stixpy/calibration/visibility.py | Use corrected livetime from get_livetime_fraction; switch default flare_location to SkyCoord and validate input. |
| stixpy/calibration/tests/test_livetime.py | Adjust tests to new return ordering and semantics of get_livetime_fraction. |
| stixpy/calibration/livetime.py | Change return values to corrected livetime and two-photon factor; internal variable renames. |
| changelog/194.bugfix.rst | Document fix for incorrect livetime correction in create_meta_pixels. |
| changelog/194.bugfix.2.rst | Document ELUT reader column name fix. |
| changelog/194.bugfix.1.rst | Document SkyCoord migration completion for calibrate_visibility. |
| .github/workflows/ci.yaml | Re-enable push and tag triggers for CI runs. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #185, #184 and #186