Corrected for STIX pointing in HPC 0,0 coordinate for imaging_demo#216
Conversation
|
Thanks for the PR made some small changes and should be good to go. It usually best to alway work on a branch e.g don't ever touch main as it can cause headache in the future. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 81.54% 81.56% +0.01%
==========================================
Files 35 35
Lines 2439 2441 +2
==========================================
+ Hits 1989 1991 +2
Misses 450 450 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates STIX imaging calibration/example usage to use the STIX frame’s pointing center (spacecraft pointing / STIX FOV center) instead of assuming an HPC (0,0) reference, and includes a few supporting time-handling and test adjustments.
Changes:
- Update
examples/imaging_demo.pyto calibrate visibilities using aSTIXImagingcenter coordinate and reflect that in the example narrative. - Adjust STIX coordinate-time handling by using midpoint arithmetic and improving
end_timehandling inget_hpc_info. - Refresh remote-data test expectations and refactor one Fido test into a parametrized form.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
stixpy/net/tests/test_client.py |
Updates remote-data expectations and refactors a Fido search test into parametrized cases. |
stixpy/coordinates/transforms.py |
Tweaks get_hpc_info end-time handling and replaces np.mean(Time(...)) with midpoint arithmetic in transforms. |
stixpy/coordinates/tests/test_transforms.py |
Updates STIXImaging SkyCoord construction style in a remote-data transform test. |
stixpy/coordinates/frames.py |
Uses midpoint arithmetic for obstime_avg and defaults obstime_end to obstime when omitted. |
stixpy/calibration/tests/test_visibility.py |
Uses explicit midpoint arithmetic and minor refactor for clarity in visibility calibration test. |
examples/imaging_demo.py |
Switches demo to use STIX FOV center for calibration and updates WCS/map setup accordingly. |
changelog/216.bugfix.rst |
Documents the example fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
The location being used to calibrate the visibilities has been changed to be the spacecraft pointing rather than [0,0]