Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: TYPO3/testing-framework
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9.0.3
Choose a base ref
...
head repository: TYPO3/testing-framework
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9.1.0
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Nov 30, 2024

  1. [TASK] Do not assertX but fail() in tearDown() (#660) 

    phpunit has a best practice that tests should usually
have at least one assertion to be sure they actually
do something. All assertions thus raise a counter that
is checked after test execution. If zero, phpunit marks
the test risky with "test has no assertion".

There are two ways to suppress this:
* Setting beStrictAboutTestsThatDoNotTestAnything="false"
  via phpunit config
* Adding #[DoesNotPerformAssertions] attribute to single
  tests to actively mark tests that do not assert something
  as legit

Our abstract UnitTestCase spoils this by always doing
assertions in tearDown(). The patch turns these
assertions into check+fail() code instead. Unit tests that
don't have assertions for whatever reason are now properly
marked as risky as intended by phpunit.

Releases: main
    @lolli42
    lolli42 authored Nov 30, 2024
    Configuration menu
    Copy the full SHA
    4d4fc36 View commit details
    Browse the repository at this point in the history
Loading