Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[TASK] Trigger assertion in assertCSVDataSet() on empty table #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[TASK] Trigger assertion in assertCSVDataSet() on empty table #653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Build/phpunit/UnitTests.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<?xml version="1.0"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.2/phpunit.xsd"
beStrictAboutTestsThatDoNotTestAnything="false"
cacheDirectory=".phpunit.cache"
cacheResult="false"
colors="true"
Expand Down
4 changes: 4 additions & 0 deletions Classes/Core/Functional/FunctionalTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,10 @@ protected function assertCSVDataSet(string $fileName): void
$hasHashField = ($dataSet->getHashIndex($tableName) !== null);
$records = $this->getAllRecords($tableName, $hasUidField, $hasHashField);
$assertions = $dataSet->getElements($tableName);
if (count($assertions) === 0) {
// Increase assertion counter to avoid "test did not perform any assertions" if testing for an empty table
self::assertThat(true, self::isTrue());
}
foreach ($assertions as $assertion) {
$result = $this->assertInRecords($assertion, $records);
if ($result === false) {
Expand Down
1 change: 0 additions & 1 deletion Resources/Core/Build/FunctionalTests.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.2/phpunit.xsd"
backupGlobals="true"
beStrictAboutTestsThatDoNotTestAnything="false"
bootstrap="FunctionalTestsBootstrap.php"
cacheDirectory=".phpunit.cache"
cacheResult="false"
Expand Down
1 change: 0 additions & 1 deletion Resources/Core/Build/UnitTests.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.2/phpunit.xsd"
backupGlobals="true"
beStrictAboutTestsThatDoNotTestAnything="false"
bootstrap="UnitTestsBootstrap.php"
cacheDirectory=".phpunit.cache"
cacheResult="false"
Expand Down