[TASK] Simplify useExistingSession setup #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost all Cests include the fully loaded routine right after the useExistingSession call. In order to ease the setup for new Cests, include the routine into useExistingSession
lolli42
reviewed
Jul 4, 2018
|
|
||
| // Ensure main content frame is fully loaded, otherwise there are load-race-conditions | ||
| $I->switchToIFrame('list_frame'); | ||
| $I->waitForText('Web Content Management System'); |
There was a problem hiding this comment.
we should also add $I->switchToIFrame(); here, so the default is to be on the main iframe after default login.
lolli42
pushed a commit
that referenced
this pull request
Jul 4, 2018
Almost all Cests include the fully loaded routine right after the useExistingSession call. In order to ease the setup for new Cests, include the routine into useExistingSession
lolli42
pushed a commit
that referenced
this pull request
Jul 25, 2018
Almost all Cests include the fully loaded routine right after the useExistingSession call. In order to ease the setup for new Cests, include the routine into useExistingSession
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all Cests include the fully loaded routine
right after the useExistingSession call. In order
to ease the setup for new Cests, include the routine
into useExistingSession