Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[TASK] Do not assertX but fail() in tearDown() #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2024
Merged

[TASK] Do not assertX but fail() in tearDown() #660

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions Classes/Core/Unit/UnitTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,13 @@ protected function tearDown(): void
$singletonInstances = GeneralUtility::getSingletonInstances();
// Reset singletons anyway to not let all further tests fail
GeneralUtility::resetSingletonInstances([]);
self::assertEmpty(
$singletonInstances,
'tearDown() integrity check found left over singleton instances in GeneralUtility::makeInstance()'
. ' instance list. The test should probably set \'$this->resetSingletonInstances = true;\' to'
. ' reset this framework state change. Found singletons: ' . implode(', ', array_keys($singletonInstances))
);
if (!empty($singletonInstances)) {
self::fail(
'tearDown() integrity check found left over singleton instances in GeneralUtility::makeInstance()'
. ' instance list. The test should probably set \'$this->resetSingletonInstances = true;\' to'
. ' reset this framework state change. Found singletons: ' . implode(', ', array_keys($singletonInstances))
);
}
}

// Delete registered test files and directories
Expand Down Expand Up @@ -175,18 +176,19 @@ protected function tearDown(): void
if (!empty($notCleanInstances)) {
// Reset instance list (including singletons & container) to not let all further tests fail
GeneralUtility::purgeInstances();
self::fail(
'tearDown() integrity check found left over instances in GeneralUtility::makeInstance() instance list.'
. ' Always consume instances added via GeneralUtility::addInstance() in your test by the test subject.'
. ' Found instances of these classes: ' . implode(', ', array_keys($notCleanInstances))
);
}
// Let the test fail if there were instances left and give some message on why it fails
self::assertEquals(
[],
$notCleanInstances,
'tearDown() integrity check found left over instances in GeneralUtility::makeInstance() instance list.'
. ' Always consume instances added via GeneralUtility::addInstance() in your test by the test subject.'
);

self::assertTrue($this->setUpMethodCallChainValid, 'tearDown() integrity check detected that setUp has a '
. 'broken parent call chain. Please check that setUp() methods properly calls parent::setUp(), starting from "'
. static::class . '"');
if ($this->setUpMethodCallChainValid === false) {
self::fail(
'tearDown() integrity check detected that setUp() has a broken parent call chain.'
. ' Please check that setUp() methods properly calls parent::setUp(), starting from "' . static::class . '"'
);
}

parent::tearDown();
}
Expand Down