fix(ui): collapse thinking blocks by default for reasoning models - #4467
Open
VedantMadane wants to merge 1 commit into
Open
fix(ui): collapse thinking blocks by default for reasoning models#4467VedantMadane wants to merge 1 commit into
VedantMadane wants to merge 1 commit into
Conversation
Remove the `open` attribute from the ThinkBlock `<details>` element so that `<think>` content from reasoning models like DeepSeek R1 is collapsed by default. Users can still expand to view the thinking process by clicking the summary. Fixes TabbyML#3977 Signed-off-by: Vedant Madane <[email protected]>
|
Collapsing |
Author
|
Thanks for the feedback. I agree that persisting the preference would be a great UX addition. However, to keep this PR atomic and minimal, I propose keeping it as a default-collapsed state for now. We can definitely explore persistence in a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3977
Removes the \open\ attribute from the \ThinkBlock\ <details>\ element so that <think>\ content from reasoning models (DeepSeek R1, etc.) is collapsed by default. Users can still expand to view the full thinking process by clicking the summary.
Change
One-line change in ^[e/tabby-ui/components/message-markdown/index.tsx:
\\diff
Details
Details
\\
The existing <think>\ tag pipeline (CUSTOM_HTML_BLOCK_TAGS, formatCustomHTMLBlockTags, rehypeSanitize, ThinkBlock component) already handles parsing correctly. The only issue was the default visibility.