feat(http-api-bindings): accept llmman model kinds - #4536
Open
ericcurtin wants to merge 1 commit into
Open
Conversation
llmman (https://github.com/llmmanorg/llmman) is a local model runner that serves the Ollama API, so llmman/completion and llmman/embedding route to the same bindings as their counterparts. Chat needs no kind of its own: llmman also serves an OpenAI-compatible API, which openai/chat already handles. Signed-off-by: Eric Curtin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llmman is a local model runner that serves the Ollama API (alongside OpenAI- and Anthropic-compatible ones), so
llmman/completionandllmman/embeddingroute to the same bindings as their counterparts.Chat needs no kind of its own — llmman also serves an OpenAI-compatible API, and
openai/chatalready handles that. Adding a third alias there would have been noise.To be straight about the scope: this is discoverability rather than new capability.
api_endpointis required for these kinds anyway, so pointingollama/completionat port 17434 works today. The distinct kind just lets it be named for what it is in config.Testing:
cargo check -p http-api-bindingspasses;cargo fmt --checkclean. Not verified against a live server.