-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: support asynchronous serialization adapter #6503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hokkyss
wants to merge
15
commits into
TanStack:main
Choose a base branch
from
hokkyss:async-adapters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+770
−20
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
21d744d
feat(serialization-adapter): async serialization adapter support
hokkyss a2a2650
ci: apply automated fixes
autofix-ci[bot] cf6dd2b
fix: remove console.logs
hokkyss 5da6060
ci: apply automated fixes
autofix-ci[bot] fa1fa2a
fix: coderabbit reviews
hokkyss eb97d6a
ci: apply automated fixes
autofix-ci[bot] 0332347
revert(router-core): remove async from makeSsrSerovalPlugin
hokkyss 8f23846
test: duplicate test to solid and vue
hokkyss 6f05cca
ci: apply automated fixes
autofix-ci[bot] ef0b0e7
fix(e2e): testid typo
hokkyss 9216260
fix: export asyncfoo class
hokkyss fef7c2a
refactor(types): split async type to be more flexible
hokkyss 005c3fa
ci: apply automated fixes
autofix-ci[bot] 4d29fec
fix(types): add asnyc output type to serialization adapter
hokkyss 32ab96b
ci: apply automated fixes
autofix-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
e2e/react-start/serialization-adapters/src/routes/server-function/class-instance.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import { createFileRoute } from '@tanstack/react-router' | ||
| import { createServerFn } from '@tanstack/react-start' | ||
| import { useState } from 'react' | ||
| import { makeAsyncFoo, makeFoo } from '~/data' | ||
|
|
||
| const serverFn = createServerFn().handler(() => { | ||
| return { | ||
| asyncFoo: makeAsyncFoo('-serverFn'), | ||
| foo: makeFoo('-serverFn'), | ||
| } | ||
| }) | ||
|
|
||
| export const Route = createFileRoute('/server-function/class-instance')({ | ||
| component: RouteComponent, | ||
| }) | ||
|
|
||
| function RouteComponent() { | ||
| const [resp, setResp] = useState<null | Awaited<ReturnType<typeof serverFn>>>( | ||
| null, | ||
| ) | ||
|
|
||
| return ( | ||
| <div> | ||
| <button | ||
| data-testid="server-function-btn" | ||
| onClick={() => serverFn().then(setResp)} | ||
| > | ||
| trigger serverFn | ||
| </button> | ||
| <div data-testid="server-function-foo-response"> | ||
| {JSON.stringify(resp?.foo?.value)} | ||
| </div> | ||
| <div data-testid="server-function-async-foo-response"> | ||
| {JSON.stringify(resp?.asyncFoo?.echo())} | ||
| </div> | ||
| </div> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.