Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(table-core): use right Document instance on getResizeHandler (column-sizing feature) #5989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2025
Merged

fix(table-core): use right Document instance on getResizeHandler (column-sizing feature) #5989

merged 3 commits into from
Apr 14, 2025

Conversation

riccardoperra
Copy link
Collaborator

@riccardoperra riccardoperra commented Apr 14, 2025 •
edited
Loading

Related to my comment #5747 (comment)

I'd consider to remove jsdom env in table-core test since since this package should be framework agnostic. It could ensure us that things doesn't break while running the code in a non browser env. wdyt?

I've added two new utils safelyAccessDocument and safelyAccessDocumentEvent just for testing purposes (actually using only safelyAccessDocument) as it can be useful to reuse that portion of code also in other files. Those utils are not currently present in public api, is it ok?

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 14, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 92b9e1e.

Command Status Duration Result
nx affected --targets=test:format,test:sherif,t... ✅ Succeeded 2m 31s View ↗
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 34s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-14 18:23:50 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 14, 2025 •
edited
Loading

More templates

@tanstack/angular-table

npm i https://pkg.pr.new/@tanstack/angular-table@5989

@tanstack/lit-table

npm i https://pkg.pr.new/@tanstack/lit-table@5989

@tanstack/match-sorter-utils

npm i https://pkg.pr.new/@tanstack/match-sorter-utils@5989

@tanstack/qwik-table

npm i https://pkg.pr.new/@tanstack/qwik-table@5989

@tanstack/react-table

npm i https://pkg.pr.new/@tanstack/react-table@5989

@tanstack/react-table-devtools

npm i https://pkg.pr.new/@tanstack/react-table-devtools@5989

@tanstack/solid-table

npm i https://pkg.pr.new/@tanstack/solid-table@5989

@tanstack/svelte-table

npm i https://pkg.pr.new/@tanstack/svelte-table@5989

@tanstack/vue-table

npm i https://pkg.pr.new/@tanstack/vue-table@5989

@tanstack/table-core

npm i https://pkg.pr.new/@tanstack/table-core@5989

commit: 92b9e1e

@riccardoperra riccardoperra mentioned this pull request Apr 14, 2025
Open
@riccardoperra riccardoperra marked this pull request as ready for review April 14, 2025 19:49
@riccardoperra riccardoperra changed the title fix(table-core): column sizing context document instance fix(table-core): use right Document instance on getResizeHandler (column-sizing feature) Apr 14, 2025
@KevinVandy KevinVandy merged commit 54ce673 into main Apr 14, 2025
4 checks passed
@KevinVandy KevinVandy deleted the fix/column-sizing-context-document-instance branch April 14, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinVandy KevinVandy KevinVandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riccardoperra @KevinVandy