Feat/#120-mobile_height_bug #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
joohaem
approved these changes
Jul 25, 2022
Member
joohaem
left a comment
There was a problem hiding this comment.
height: calc(var(--vh, 1vh) * 100);
min-height: -webkit-fill-available;속성 추가로 ios 에서 풀화면 잘 동작되는 걸까요??! 바로 머지해도 좋을 것 같아요!
| position: relative; | ||
| width: 30rem; | ||
| height: 52.5rem; |
Member
There was a problem hiding this comment.
해당 속성 없어도 될 거 같아요 !
card 관련 css 는 CardCollection/CardSlider/style.ts 에서 적용되어있고,
.slick-slide (카드 wrapper) 에서 max-height 속성을 적용시켰기 때문에, heigth 속성이 제대로 먹지 않아서 삭제해도 좋을 것 같네요!
NaveOWO
reviewed
Jul 26, 2022
| MainPage: styled.main` | ||
| /* height: calc(var(--vh, 1vh) * 100); */ | ||
| height: 100vh; | ||
| height: calc(var(--vh, 1vh) * 100); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
📌 내가 알게 된 부분
📌 질문할 부분
📸 스크린샷