Feat/#185 moodpiickle design #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
joohaem
approved these changes
Jan 22, 2023
Member
joohaem
left a comment
There was a problem hiding this comment.
고생해쒀요...!!!!!
나중에 리뷰 남긴 거랑 그라데이션만 추가해서 머지합시다!
src/style/theme.ts
Outdated
| body1: FONT({ weight: 600, size: 2.4, lineHeight: 140, letterSpacing: 3 }), | ||
| body2: FONT({ weight: 600, size: 2.0, lineHeight: 140, letterSpacing: 0 }), | ||
| body3: FONT({ weight: 500, size: 1.8, lineHeight: 140, letterSpacing: 35 }), | ||
| body3: FONT({ weight: 500, size: 1.8, lineHeight: 140, letterSpacing: 3.5 }), |
Member
There was a problem hiding this comment.
letter-spacing: -0.0${letterSpacing}rem;
이렇게 되어있어서 -0.03.5rem 이 되어버립니다
Contributor
Author
There was a problem hiding this comment.
아 구렇구나,,! 잘못 표기된줄 알고 수정했오😅😅 바로 수정할게요오
joohaem
requested changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
📌 내가 알게 된 부분
👀 이모지 생성 관련 배운 지식 👀
String.fromCodePoint(parseInt(item.unicode, 16))이렇게 16진수 코드만 넣어주면 그에 맞는 문자열을 반환해주는 메서드가 있다는 점을 알게 되었습니다.&#x를 붙이면 16진수,&#만 붙이면 10진수!📸 스크린샷