Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@joohaem
Copy link
Member

@joohaem joohaem commented Feb 4, 2023

  • 브랜치명, 브랜치 알맞게 설정
  • Reviewer, Assignees, Label, Milestone, Issue(PR 작성 후에) 붙이기
  • PR이 승인된 경우 해당 브랜치는 삭제하기

📌 내용

  • GTM 코드 다 심었습니다 ..... 2시간....
  • 문자열 객체 따로 빼놔서 import 해서 사용해요, 수정 필요한 거 있으면 해당 객체에서 수정하면 됩니다!

📌 질문할 부분

  • 하나하나 테스트하기엔 너무 무리일 것 같고, GTM 객체 부분만 한 번 더블체킹해주시면 감사합니다!! (오탈자)

@joohaem joohaem requested a review from NYeonK February 4, 2023 09:22
@joohaem joohaem self-assigned this Feb 4, 2023
@joohaem joohaem linked an issue Feb 4, 2023 that may be closed by this pull request
7 tasks
@NYeonK NYeonK mentioned this pull request Feb 4, 2023
16 tasks
Copy link
Contributor

@NYeonK NYeonK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와우 겁나 많다,, 고생 많았어 징쨔ㅠㅠ🤣👍👍👍
오탈자 확인 완료! 없습니당@@!

✨✨이주함 최고✨✨

main아이스브레이킹: "click_main_mood_ice",
main커플: "click_main_mood_couple",
main친구: "click_main_mood_friend",
"main진지한 대화": "click_main_mood_deep",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진지한 대화 요거는 꼭 띄어쓰기 해야 하는 이유가 있는걸까요?-?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

서버에서 "진지한 대화" string 으로 넘겨줘서!! 그 값으로써 사용하기 위해서에요 !~

Comment on lines 132 to 134
piickleMe1: "click_vote_1",
piickleMe2: "click_vote_2",
piickleMe3: "click_vote_3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(구글 시트) 유의미하냐는 질문에 pm이 패스하자고 답변남겼습니다~!
지워도 될 것 같아여~.~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아우 !! 감사합니다!~

@joohaem joohaem merged commit 47baa5c into release/1.2 Feb 5, 2023
@joohaem joohaem deleted the feat/#196-modify_gtm branch February 5, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ Common ] GTM 수정 작업

3 participants