Feat/#213 menubar #214
Merged
Feat/#213 menubar #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/1.3 from forked Release/1.3
11 tasks
joohaem
reviewed
Feb 26, 2023
Comment on lines
33
to
37
| const openElement = useOutClickCloser({ | ||
| handleOutClickCloser: () => { | ||
| closeMenuBar(); | ||
| }, | ||
| }); |
Member
There was a problem hiding this comment.
아 이제 아웃클릭 코드들 보니까 되게 신기하게 짰네???
먼가 더 보편적인 방법으로는,
export default function useOutClickCloser(handleOutClickCloser: () => void;) {이렇게 props 인자가 아닌, 콜백함수 인자로 받아와서
Suggested change
| const openElement = useOutClickCloser({ | |
| handleOutClickCloser: () => { | |
| closeMenuBar(); | |
| }, | |
| }); | |
| const outClickRef = useOutClick(closeMenuBar); //ref 임을 명시해주는 변수명이 더 좋을 것 같아! |
나라면 이런 식으로 사용할 것 같다 !!
객체로 감싸서 넘겨주는 게, 그 "객체 안에 내용"만 바뀌면 "바뀐 줄 모르는" 현상이 일어나서
저렇게 인자 인수 형태로 넘겨주는 게 더 좋지 않을까 싶다!
이 외에도, 컴포넌트에서도 prop로 넘겨줄 때 객체형보다는 최대한 원시 자료형으로 객체를 분리해서 하나하나 넘겨주는 게 더 정확하고 효율적으로 렌더링(최적화) 되거든!
Contributor
Author
There was a problem hiding this comment.
오홍 그렇구나😮😮 해보고 있는데ㅓ 콜백함수 인자로 전달해주는 부분을 어떻게 해야할지 잘 모르게써요!..!
Contributor
Author
There was a problem hiding this comment.
useOutClick는 useOutClickCloser 요거를 바꿔서 쓴걸까요?-?
joohaem
reviewed
Feb 26, 2023
NYeonK
commented
Feb 26, 2023
|
|
||
| export default function useOutClickCloser(props: UseOutClickCloserProps) { | ||
| const { handleOutClickCloser } = props; | ||
| type HandleOutClickCloser = () => void; |
Contributor
Author
There was a problem hiding this comment.
아항 요로코롬 하는 거구나👀👀 배워갑니다아><
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
📌 질문할 부분
<link to = {} />여기 router 부분도 따로 빼려고 했는데 아래 코드에서ballotLists는 안에서 선언한거라 못빼더라구요?-?으떠한 방법이 있을까나요😵
`${routePaths.Vote}/${ballotLists?.data[0]._id}`📸 스크린샷