Fix/#215 keep join infos #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7 tasks
NYeonK
reviewed
Feb 28, 2023
Comment on lines
30
to
37
| if (year === time.getFullYear() && monthResult >= time.getMonth() + 1 && day >= time.getDate()) { | ||
| errorMsg("birthValid"); | ||
| handleErrorMsg(JOIN_ERROR_KEY.birth.valid); | ||
| } else if (year > time.getFullYear()) { | ||
| errorMsg("birthValid"); | ||
| handleErrorMsg(JOIN_ERROR_KEY.birth.valid); | ||
| } else if (age < 14) { | ||
| errorMsg("birthCheck"); | ||
| handleErrorMsg(JOIN_ERROR_KEY.birth.check); | ||
| } else { | ||
| errorMsg(""); | ||
| handleErrorMsg(JOIN_ERROR_KEY.Okay); |
Contributor
There was a problem hiding this comment.
에러메세지가 상수로 넣으니까 보기에 더 깔끔해진 것 같아요!!
| <St.NickNameInputForm | ||
| id="nickname" | ||
| placeholder="홍길동" | ||
| defaultValue={nickName} |
Contributor
There was a problem hiding this comment.
변하는 값이면 defaultValue을 써야하는구나?!@!@ 처음 알았다!!!
Comment on lines
+3
to
+11
| nickName: { | ||
| input: "nickNameInput", | ||
| // check: "닉네임 중복 확인을 해주세요", | ||
| valid: "nickNameValid", | ||
| fail: "nickNameFail", | ||
| // success: "사용가능한 닉네임입니다", | ||
| }, | ||
| birth: { | ||
| // input: "생년월일을 입력해주세요", |
Member
There was a problem hiding this comment.
ALERT_MESSAGE 랑 키가 align 되어야 어색하지 않으려나 했는데,
일단 해당 라인들은 제거할게요 !!
|
|
||
| <St.SubTitle>성별(선택)</St.SubTitle> | ||
| <ProfileGender isSelected={isSelected} setIsSelected={setIsSelected} /> | ||
| <ProfileGender gender={gender} setGender={setGender} /> |
| }); | ||
|
|
||
| const [isPickedItems, setIsPickedItems] = useState<boolean[]>([false, false, false, false, false]); | ||
| const [isPickedItems, setIsPickedItems] = useState<boolean[]>([false, true, true, true, false]); |
Comment on lines
+21
to
+32
| <Outlet | ||
| context={{ | ||
| userInfoFormDataForPost: userInfoFormData, | ||
| formDataEmailValue: userInfoFormData.get(JOIN_FORM_DATA_KEY.Email) ?? "", | ||
| formDataPasswordValue: userInfoFormData.get(JOIN_FORM_DATA_KEY.Password) ?? "", | ||
| formDataNicknameValue: userInfoFormData.get(JOIN_FORM_DATA_KEY.Nickname) ?? "", | ||
| formDataBirthdayValue: userInfoFormData.get(JOIN_FORM_DATA_KEY.Birthday) ?? "", | ||
| formDataGenderValue: userInfoFormData.get(JOIN_FORM_DATA_KEY.Gender) ?? "", | ||
| formDataImgFile: userInfoFormData.get(JOIN_FORM_DATA_KEY.ImgFile), | ||
| setUserInfoFormData, | ||
| }} | ||
| /> |
Contributor
There was a problem hiding this comment.
아쥬 굿!~!! formData.get도 배워갑니다아ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
3hjoin
Feat이전으로 돌아가도 정보가 남아있습니다. (defualt 값 설정 :: 이메일, 비밀번호, 프로필사진, 닉네임, 생일, 성별)join/user-profile
Fix닉네임 중복 이후에 다음 단계로 넘어갈 수 있습니다.join/agree
Feat동의 페이지에서, 필수 조건들에 기본적으로 체크 처리를 해놓았습니다. (토스 앱에서 "필수"인 값에 먼저 체크를 해놓고, "선택" 부분만 사용자가 체크하도록 UI/UX를 구성해놓았는데, 편리한 것 같아서 해봤어요 하하😇😇 이거는 dev 반영 이후에 기획측 확인을 받으려구요!!)Fix회원가입 POST 통신이 안됐는데(창을 나갔다와서 값이 사라진 상황이라던가 하는... , 로그인 페이지로 넘어가는 현상이 있어서, alert로 에러 메시지를 띄워주도록 구성했어요. 이것도 이후에 기획측 확인을 받을게요!!📸 스크린샷