Feat/#233 menubar #240
Merged
Feat/#233 menubar #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 23, 2023
Closed
joohaem
approved these changes
Mar 23, 2023
Member
joohaem
left a comment
There was a problem hiding this comment.
QA 보면, 메뉴바에서 로그인이나 회원가입 버튼을 눌렀을 때 아무런 액션이 없었다고도 같이 적혀있는데,
어딘가에 로그인이 되어있는 상태여ㅆ나봐요~ Refresh Token이 필요할 것 같긴하네욥😏😏
그러게요 ,, 서버팀 안 바쁠 때 소셜로그인이랑 같이 작업하자고 해봅시당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
Xicon 위치 수정, 메뉴바 목록 문구 수정)📌 내가 알게 된 부분
로그인이 되어 있을 경우에만 마이피클을 이용할 수 있게 해달라는 메뉴바 QA가 있었는데요!
확인해보니까 잘 동작합니다! (PM 폰에서도 확인 완료😋)
QA 보면, 메뉴바에서 로그인이나 회원가입 버튼을 눌렀을 때 아무런 액션이 없었다고도 같이 적혀있는데,
어딘가에 로그인이 되어있는 상태여ㅆ나봐요~ Refresh Token이 필요할 것 같긴하네욥😏😏
📸 스크린샷