[Feature][Card Collection] min Header + 필터 모달 #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NYeonK
reviewed
Apr 12, 2023
Contributor
NYeonK
left a comment
There was a problem hiding this comment.
징짜 므싯는 사람..✨😎👍🤩
열심히 코드 읽었습니당:) 버튼 안보이게 하는거 어떻게 만들지 궁금했는데 역시 오빤 최고야
고생했오야~!~!!!!!!!
| import St from "./style"; | ||
|
|
||
| type ModalTheme = "DEFAULT" | "WHITE" | "GRAY"; | ||
| type ModalTheme = "DEFAULT" | "WHITE_BOTTOM" | "GRAY_BOTTOM"; |
Contributor
There was a problem hiding this comment.
_BOTTOM 붙인 거 좋아요~!~!! 어떤 모달인지 생각하는 시간도 줄어들 것 같네용ㅎ
| </St.ModalContentsWrapper> | ||
|
|
||
| <St.CheckRandomWrapper onClick={() => setShouldRandom((prev) => !prev)}> | ||
| <p>랜덤으로 카드를 보여주세요</p> |
Contributor
There was a problem hiding this comment.
태그 없어도 괜찮지 않을까요?! 필요하다면 St로 바꿔줍시당~😚
Comment on lines
+4
to
+7
| <rect width="16" height="16" fill={isChecked ? "#19BE7E" : "#E0E0E0"} /> | ||
| <path | ||
| d="M3 7.88235L5.96021 11.1734C6.35748 11.6151 7.04992 11.6151 7.44719 11.1734L13 5" | ||
| stroke={isChecked ? "white" : "#C2C2C2"} |
Comment on lines
+49
to
+56
| const bottomUp = keyframes` | ||
| from { | ||
| transform: translateY(60rem); | ||
| } | ||
| to { | ||
| transform: translateY(0); | ||
| } | ||
| `; |
| } | ||
| setIsVisibleCTAButton(false); | ||
| }, | ||
| { threshold: 0.3 }, |
Contributor
There was a problem hiding this comment.
요거는 버튼이 화면에 30%으로 이상 보일 때를 말하는 걸까요?-? 0.3의 기준이 궁금합니당
Member
Author
There was a problem hiding this comment.
맞아요 !!~ 화면(viewport)에 30%가 보일 때(intersect) 콜백함수가 동작합니다!
NYeonK
approved these changes
Apr 12, 2023
Member
Author
Add
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
4hWHITE_BOTTOM으로 태깅을 바꿨어요GRAY_BOTTOM으로 태깅을 수정하였습니다! (가운데에 오는지, 아래에 붙어있는지 구분하기 위함) 피드백 해주세요!!~📌 내가 알게 된 부분
📸 스크린샷
2023-04-11._2.mp4