Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug/#269 filter modal #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joohaem merged 2 commits into from
Apr 24, 2023
Merged

Bug/#269 filter modal #273

joohaem merged 2 commits into from
Apr 24, 2023

Conversation

@NYeonK
Copy link
Contributor

@NYeonK NYeonK commented Apr 23, 2023

  • 브랜치명, 브랜치 알맞게 설정
  • Reviewer, Assignees, Label, Milestone, Issue(PR 작성 후에) 붙이기
  • PR이 승인된 경우 해당 브랜치는 삭제하기

📌 내용

  • 카드 필터에서 랜덤 버튼을 없애고, 여백을 수정합니다.

📌 질문할 부분

  • 추후 반영 예정이라 일단 주석 처리했는데, 어떻게 생각하시는지요?-?

📸 스크린샷

@NYeonK NYeonK self-assigned this Apr 23, 2023
@NYeonK NYeonK linked an issue Apr 23, 2023 that may be closed by this pull request
[ Common ] QA 반영 #269
Closed
10 tasks
@NYeonK NYeonK mentioned this pull request Apr 23, 2023
Closed
10 tasks
@NYeonK NYeonK requested a review from joohaem April 23, 2023 13:33
joohaem
joohaem approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@joohaem joohaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일시적으로 주석처리하는 것 좋습니다!

@joohaem joohaem merged commit f3f4ba6 into release/1.4.0 Apr 24, 2023
@joohaem joohaem deleted the bug/#269-filter_modal branch April 24, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joohaem joohaem joohaem approved these changes

Assignees

@NYeonK NYeonK

Labels

Fix 나연

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ Common ] QA 반영

3 participants

@NYeonK @joohaem