Feat/#317 coach mark #319
Merged
Feat/#317 coach mark #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
joohaem
reviewed
Aug 15, 2023
Comment on lines
+5
to
+14
| export default function useCoachMark() { | ||
| const [isOpened, setIsOpened] = useState(false); | ||
|
|
||
| useEffect(() => { | ||
| const isCoachMarkShown = localStorage.getItem(COACH_MARK_SESSION_KEY); | ||
| if (!isCoachMarkShown || isOpened) { | ||
| setIsOpened(true); | ||
| localStorage.setItem(COACH_MARK_SESSION_KEY, "true"); | ||
| } | ||
| }, []); |
Member
There was a problem hiding this comment.
이 훅을 코치마크 키로 하드코딩 하는 거랑,
세션 키를 받아서 로컬스토리지로써 state를 조작하는 훅으로 만드는 거랑
장단점이 어떻게 될 것 같나요?
Contributor
Author
There was a problem hiding this comment.
코치마크 키로 하드 코딩은 어떻게 하는
걸 말하나요?👀
ilmerry
approved these changes
Aug 15, 2023
| import * as St from "./style"; | ||
|
|
||
| type ModalTheme = "DEFAULT" | "WHITE_BOTTOM" | "GRAY_CENTER" | "GRAY_BOTTOM"; | ||
| type ModalTheme = "DEFAULT" | "WHITE_BOTTOM" | "GRAY_CENTER" | "GRAY_BOTTOM" | "COACHMARK"; |
Member
There was a problem hiding this comment.
아하 이런걸 choach mark 라고 하는군요! 배워갑니다👍
Comment on lines
22
to
34
| if (theme === "COACHMARK") | ||
| return ( | ||
| <ModalPortal> | ||
| <St.CoachMarkRoot> | ||
| <St.CoachMarkModal ref={outClickCloserRef}> | ||
| <St.CloseBtn type="button" onClick={closeHandler}> | ||
| <IcModalCloseBtn /> | ||
| </St.CloseBtn> | ||
| <St.ModalContents>{children}</St.ModalContents> | ||
| </St.CoachMarkModal> | ||
| </St.CoachMarkRoot> | ||
| </ModalPortal> | ||
| ); |
Member
There was a problem hiding this comment.
근데 이 Modal 컴포넌트, 계속 이렇게 theme 추가해서 쓰는게 재사용하고 거리가 멀다는 생각이 들어요
차라리 제어권을 호출측에 넘기는 건 어떨지 생각해보면 좋을 것 같아요! 토스트, 모달, 코치마크 전부!
토스의 useOverlay
Contributor
Author
There was a problem hiding this comment.
오왕 좋은 인사이트 감사해요👍🌟
이번 스프린트가 끝나고 리팩토링해보면 좋을 것 같슴니다! 끝나고 함 이야기 해봐용🙇♀️🙇♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
📸 스크린샷