Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@NYeonK
Copy link
Contributor

@NYeonK NYeonK commented Aug 23, 2023

  • 브랜치명, 브랜치 알맞게 설정
  • Reviewer, Assignees, Label, Milestone, Issue(PR 작성 후에) 붙이기
  • PR이 승인된 경우 해당 브랜치는 삭제하기

📌 내용

  • 4번째 스프린트에 맞게 GTM을 삽입합니다.
  • 띠배너의 아이콘을 변경했습니다. (디자인QA)

📌 질문할 부분

  • className이라고 변수명을 지었는데, className={className}이 헷갈릴까요? 변수명을 gtmClassName으로 바꿀지말지 고민이네요! -> 변경해봤습니다😊

@NYeonK NYeonK self-assigned this Aug 23, 2023
@NYeonK NYeonK linked an issue Aug 23, 2023 that may be closed by this pull request
4 tasks
@NYeonK NYeonK marked this pull request as ready for review August 23, 2023 17:46
@NYeonK NYeonK requested a review from ilmerry August 24, 2023 05:38
@NYeonK NYeonK linked an issue Aug 24, 2023 that may be closed by this pull request
6 tasks
Copy link
Member

@ilmerry ilmerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하나하나 넣느라 힘들었을텐데,, 수고많으셨습니다🫶🏻🎉

@NYeonK NYeonK merged commit 60b759b into release/2.1.0 Aug 24, 2023
@NYeonK NYeonK deleted the feat/#323-gtm branch August 24, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ Common ] GTM 삽입 [ Common ] QA 반영

3 participants