Feat/#330 event banner #331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
ilmerry
approved these changes
Aug 26, 2023
|
|
||
| if (isLogin) { | ||
| return ( | ||
| <St.EventContainer to="" className={GTM_CLASS_NAME.mainBannerEvent}> |
Member
There was a problem hiding this comment.
여기서 바로 머지해도될 것 같아요! /card-collection?type=event로 이동해야하니까
${routePaths.CardCollection}?type=${LocationType.EVENT}로 해주시면 될 것 같습니다!
Contributor
Author
There was a problem hiding this comment.
넵 반영해서 먼저 머지할게요~! 경로 진입 잘되는지 이따 확인부탁드릴게요:)
Comment on lines
+14
to
+19
| <St.Content className={GTM_CLASS_NAME.mainBannerEvent} islogin={isLogin}> | ||
| 이벤트 참여하고 치킨 받아가세요! | ||
| </St.Content> | ||
| <St.SubContent className={GTM_CLASS_NAME.mainBannerEvent} islogin={isLogin}> | ||
| 피클의 미래 모습을 체험해 볼 수 있어요! | ||
| </St.SubContent> |
Member
There was a problem hiding this comment.
여기서의 islogin은 반드시 true로 들어가지 않나요?!
Contributor
Author
There was a problem hiding this comment.
넵ㅎㅎ 기존 띠배너랑 동일한 태그를 썼기 때문에, 폰트 색 구분을 위헤 넣은 값입니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
📸 스크린샷