Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Feature - rates #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Sep 26, 2025
Merged

Feature - rates #19

merged 28 commits into from
Sep 26, 2025

Conversation

yawlhead91
Copy link
Contributor

@yawlhead91 yawlhead91 commented Aug 21, 2025 •
edited
Loading

Description

This PR adds comprehensive support for Teamwork's rates management API, enabling
management of installation, project, and user-specific billing rates through the
Go SDK.

Key Features:

  • Installation-wide rate management
  • Project-specific rate configuration
  • User rate management with project overrides
  • Rate history tracking and pagination support
  • Multi-currency rate handling

This functionality is required for the upcoming MCP server integration to provide
rate management capabilities to external clients.

Testing:

  • Full test coverage with integration tests
  • Fixed API endpoint compatibility issues
  • Validated against actual API responses

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Testing

  • Tests pass locally (go test -v ./...)
  • Added/updated tests for new functionality

Checklist

  • Code follows project style guidelines
  • Self-reviewed the code
  • Added necessary documentation
  • No new warnings or errors

@yawlhead91
add rates - init
dc739e6 
go lint errors

fix payloads

go fmt

remove currency for testing

rates lint
@yawlhead91 yawlhead91 marked this pull request as ready for review August 28, 2025 12:21
@yawlhead91 yawlhead91 requested a review from a team as a code owner August 28, 2025 12:21
@yawlhead91 yawlhead91 mentioned this pull request Aug 29, 2025
Draft
10 tasks
rafaeljusto
rafaeljusto reviewed Sep 1, 2025
View reviewed changes
@yawlhead91
Copy link
Contributor Author

Rafael, I sorted out those issues, but what region is the test installation on? I can not find tw-test-eu-* site in any region to enable MC, so I can write some tests for them

@rafaeljusto
Copy link
Contributor

but what region is the test installation on?

It's a custom domain for my test installation in EU: https://tw-test-eu.rafael.net.br/ (#488712)

We should probably replace this with some other installation at some point.

rafaeljusto
rafaeljusto reviewed Sep 10, 2025
View reviewed changes
@rafaeljusto
Copy link
Contributor

I sorted out those issues

Hey Alex, there were some unresolved issues, maybe you missed those because they are hidden:
image

Would you mind having another look? I'm trying to be more strict here so we can facilitate SDK users from using the library without chasing documentation/support.

rafaeljusto
rafaeljusto approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@rafaeljusto rafaeljusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 👏 Thanks for working on this.

Could you please squash the commits before merging? It should help to keep the feature changes in a single patch.

@yawlhead91
Copy link
Contributor Author

yawlhead91 commented Sep 19, 2025 •
edited
Loading

Nice one @rafaeljusto, of course.

@yawlhead91 yawlhead91 merged commit 50ebe5a into main Sep 26, 2025
2 checks passed
@yawlhead91 yawlhead91 deleted the rates branch September 26, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafaeljusto rafaeljusto rafaeljusto approved these changes

@chrismccormack chrismccormack Awaiting requested review from chrismccormack

@tonisanta tonisanta Awaiting requested review from tonisanta

@pkk0-shared pkk0-shared Awaiting requested review from pkk0-shared

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yawlhead91 @rafaeljusto