Fix secret_mafia bug - #155
Open
MozerWang wants to merge 1 commit into
Open
Conversation
MozerWang
commented
Aug 12, 2025
- modify prompt to improve clearity: add detailed mafia rules at the beginning; add instuction format on discussion and vote;
- fix the action to observation bug: observation might be empty
- fix winning bug: len(mafia_alive) >= len(villagers_alive)
1.modify prompt to improve clearity: add mafia rule to the beginning; 2.fix the action to observation bug 3.fix winning bug
Collaborator
|
Thanks for this @MozerWang — the prompt-clarity and observation-formatting ideas here are good and worth landing. Since the branch has been idle for a while, I've picked the work up in #199, which builds on your changes with a couple of adjustments:
#199 verifies the game end-to-end deterministically (both win branches, quote-stripping, 12 seeded full episodes). Recommend closing this in favour of #199 once maintainers have had a look — happy to fold in any feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.