Fix KuhnPoker chip accounting bugs - #189
Open
nph4rd wants to merge 2 commits into
Open
Conversation
Collaborator
|
Ready to merge. Both bugs are real and correctly fixed:
I traced all four terminal lines of the action tree (check-bet-call, bet-fold, check-bet-fold, check-check): pot and per-player chips are now zero-sum and correct, and the deduction fires for the acting player before tree navigation, so resolution ordering is right. Relies on |
Collaborator
|
Verified both fixes.
Deterministic check (fixed deal): chips stay zero-sum; check/check → ±1 swing, bet+call → ±2, and fold-before-call costs only the ante. LGTM, recommend merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in _init_round / step: