Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix SyntaxError in Klondike-v0 - #192

Open
dx2102 wants to merge 1 commit into
TextArena:mainfrom
dx2102:fix/klondike-syntax-error
Open

Fix SyntaxError in Klondike-v0#192
dx2102 wants to merge 1 commit into
TextArena:mainfrom
dx2102:fix/klondike-syntax-error

Conversation

@dx2102

@dx2102 dx2102 commented Jul 7, 2026

Copy link
Copy Markdown

Cloning main and trying to import the Klondike env fails at parse time:

git clone --depth 1 https://github.com/LeonGuertler/TextArena.git
cd TextArena
python -m py_compile textarena/envs/Klondike/env.py
  File "textarena/envs/Klondike/env.py", line 119
    elif self.state.game_state["turn_count"] >= self.max_turns:
    ^^^^
SyntaxError: invalid syntax

So ta.make("Klondike-v0") has been broken since the env was added in #154.

Cause & fix

Line 119's elif was indented to the outer if/else level, but the surrounding else: had already opened — Python can't chain elif onto a closed else. From context it was meant to chain onto if self.klondike.is_won(): inside the else block. Indented the elif and its body one level. No behavior change beyond making the module importable.

Verification

python -m py_compile textarena/envs/Klondike/env.py                                        # exit 0
python -c "import textarena as ta; ta.make('Klondike-v0').reset(num_players=1, seed=42)"   # OK

@dx2102
Fixed SyntaxError in Klondike-v0 caused by mis-indented elif branch
221b282 
The elif checking turn_count >= max_turns was written at the outer
if/else level, but the else block above had already been opened, so
Python raised SyntaxError at import time. Any use of Klondike-v0
would fail immediately.

Moved the elif so it correctly chains to the 'if is_won()' check
inside the else block, matching the original intent of 'if won ->
elif ran out of turns -> otherwise continue playing'.
@borgr

borgr commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Ready to merge. This fixes a hard SyntaxError that blocks importing Klondike-v0 entirely — the elif ... turn_count >= self.max_turns: was dangling at the outer if/else level. Re-indenting it to chain onto if self.klondike.is_won(): is the correct fix and matches the intent (win → reward 52, else partial reward at max turns). Scoped to one file, no other behavior change.

(Note: the repo runs no CI on PRs, so this was verified by inspection against main rather than a check run.)

@borgr

borgr commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Verified. textarena/envs/Klondike/env.py currently fails to import under Python 3.11 with SyntaxError: invalid syntax — the elif was dedented to the if forfeit_requested: / else: level, i.e. an elif following an else. Re-indenting it under if self.klondike.is_won(): both fixes the parse and gives the intended control flow (win → reward 52; else-if turn_count >= max_turns → partial score). Confirmed: imports cleanly and a full episode terminates via the max-turns branch.

LGTM, recommend merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dx2102 @borgr