Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: two player bomber man env - #93

Open
romirthedev wants to merge 1 commit into
TextArena:mainfrom
romirthedev:patch-6
Open

feat: two player bomber man env#93
romirthedev wants to merge 1 commit into
TextArena:mainfrom
romirthedev:patch-6

Conversation

@romirthedev

@romirthedev romirthedev commented Apr 23, 2025

Copy link
Copy Markdown

bomber man environment

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #123 if this solves the issue #123

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New game (adds a new game to TextArena)
  • Game enhancement (improves an existing game)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Refactoring (code improvement without changing functionality)

Game-specific changes

If your PR adds or modifies a game, please specify:

  • Game affected:
  • Changes to game mechanics:
  • Changes to game UI/rendering:
  • Changes to game judging/rules:

Implementation Details

  • Subtask 1
  • Subtask 2
  • Subtask 3

Testing

Describe the tests you've done to verify your changes. For game-specific changes, describe how you've tested the game mechanics.

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the contribution guidelines. (required)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes. (required for bug fixes or new features)
  • All new and existing tests passed.
  • For game changes, I have verified that the game still runs correctly end-to-end.

bomber man environment
@Benjamin-eecs Benjamin-eecs changed the title two player bomber man env feat: two player bomber man env Apr 23, 2025
@borgr

borgr commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Thanks for this, @romirthedev! Like #92, this targets an older State/observation API and no longer imports against current main. The game is complete, so I've ported it forward to the current API, fixed a couple of small bugs (spawn landing on an indestructible pillar; double-bombing a cell), and verified it end-to-end (bomb-kill win / mutual-destruction draw / round-limit draw / invalid-move handling, plus a random-play smoke across seeds) in #198, crediting you. Reviewers can land whichever they prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants