Fix #3809 IndexError: pop from empty list with Rich progress bar in 14.1.0#3811
Open
sam31046 wants to merge 3 commits intoTextualize:masterfrom
Open
Fix #3809 IndexError: pop from empty list with Rich progress bar in 14.1.0#3811sam31046 wants to merge 3 commits intoTextualize:masterfrom
sam31046 wants to merge 3 commits intoTextualize:masterfrom
Conversation
…s bar in 14.1.0 Fix Textualize#3809 IndexError: pop from empty list with Rich progress bar in 14.1.0 ## Type of changes * [x] Bug fix * [ ] New feature * [ ] Documentation / docstrings * [ ] Tests * [ ] Other ## Checklist * [ ] I've run the latest [black](https://github.com/psf/black) with default args on new code. * [ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate. * [ ] I've added tests for new code. * [x] I accept that @willmcgugan may be pedantic in the code review.
|
Hi @willmcgugan, Sorry to bother you, but could you please review and merge this PR? The recent version release introduced a breaking change that is causing PyTorch Lightning CI failures. We could either restrict the version or create another PR to handle the breaking change (link, but I believe this PR is the cleanest and most future-proof way to address it. Thanks for creating the Rich library! Regards, |
Author
|
Hi @willmcgugan , I saw other libraries kept mentioning #3809 , and this PR should solve it. Please let me know if you want me to provide additional info to help this PR merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #3809 IndexError: pop from empty list with Rich progress bar in 14.1.0
Type of changes
Checklist
Description
Fix #3809