don't strip whitespace when soft_wrap is True#3937
Merged
willmcgugan merged 4 commits intomasterfrom Jan 23, 2026
Merged
Conversation
6 tasks
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3937 +/- ##
==========================================
+ Coverage 97.84% 97.86% +0.02%
==========================================
Files 74 96 +22
Lines 8152 8335 +183
==========================================
+ Hits 7976 8157 +181
- Misses 176 178 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
wingding12
added a commit
to wingding12/rich
that referenced
this pull request
Jan 30, 2026
When soft_wrap=True, the console sets overflow='ignore'. The previous fix for Textualize#3937 (trailing whitespace) caused the wrap() method to skip justification entirely when overflow='ignore', resulting in table titles being left-aligned instead of centered. The fix restructures the wrap() method to: 1. Always create new_lines and apply justification 2. Only skip truncation when overflow='ignore' (not justification) Fixes Textualize#3948
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3841