Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@TristanLecallier
Copy link
Contributor

Description

I notice a regression in ifcPropertiesProcessor getProperties function :

  • model.getProperties is not call with "await" whereas the function is asynchronous
  • getPsetProperties and getNestedPsets are call with model (FragmentsGroup) as parameter instead of model.getLocalProperties().

Additional context


What is the purpose of this pull request?

  • [ x] Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • [x ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x ] Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • [ x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@K1vs
Copy link

K1vs commented Mar 15, 2024

Fix for: #324

@HoyosJuan HoyosJuan merged commit 9aa8ba1 into ThatOpen:main Mar 29, 2024
development-ac pushed a commit to Active-Collective/ac_engine_components that referenced this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants