fix: FaceMeasurement for Multiple Models #533 #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a misalignment of the label and highlighted area of any model that is not loaded in the center of the grid. Therefore when more than 1 model is added or the position of the model changes we get a wrong positioned label. The reason is the position of the mesh comes from the geometry value that it does not update its position values relatively to the rest of the world. Therefore I have added a line of code to update the selected mesh's position based on its position coordinates outside of its geometry that reference the position correctly. Reviewed-By: Goulielmos Floros Refs: ThatOpen#533
development-ac
pushed a commit
to Active-Collective/ac_engine_components
that referenced
this pull request
Aug 18, 2025
There is a misalignment of the label and highlighted area of any model that is not loaded in the center of the grid. Therefore when more than 1 model is added or the position of the model changes we get a wrong positioned label. The reason is the position of the mesh comes from the geometry value that it does not update its position values relatively to the rest of the world. Therefore I have added a line of code to update the selected mesh's position based on its position coordinates outside of its geometry that reference the position correctly. Reviewed-By: Goulielmos Floros Refs: ThatOpen#533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a misalignment of the label and highlighted area of any model that is not loaded in the center of the grid. Therefore when more than 1 model is added or the position of the model changes we get a wrong positioned label.
The reason is the position of the mesh comes from the geometry value that it does not update its position values relatively to the rest of the world.
Therefore I have added a line of code to update the selected mesh's position based on its position coordinates outside of its geometry that reference the position correctly.
Reviewed-By: Goulielmos Floros
Refs: #533
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).