Thanks to visit codestin.com
Credit goes to github.com

Skip to content

improve median #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raklaptudirm merged 4 commits into from
Dec 20, 2021
Merged

improve median #869

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75c65a1
median
RuSaG0 Dec 9, 2021
ace5b8c
[/pull/869] make fn pure
RuSaG0 Dec 19, 2021
ce5e115
[/pull/869/] pure averageMedian fn
RuSaG0 Dec 20, 2021
57dfbd6
[/pull/869] formatter
RuSaG0 Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions Maths/AverageMedian.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,5 @@
/*
* Median: https://en.wikipedia.org/wiki/Median
*
* function averageMedian
* to find the median value of an array of numbers
* the numbers in an array will be sorted in ascending order by the function sortNumbers
* if the length of the array is even number, the median value will be the average of the two middle numbers
* else if the length of the array is odd number, the median value will be the middle number in the array
*/

const averageMedian = (numbers) => {
const averageMedian = (_numbers) => {
Comment thread
raklaptudirm marked this conversation as resolved.
Outdated
let numbers = [..._numbers];
Comment thread
raklaptudirm marked this conversation as resolved.
Outdated
let median = 0
const numLength = numbers.length
numbers = numbers.sort(sortNumbers)
Expand All @@ -19,11 +10,11 @@ const averageMedian = (numbers) => {
median = numbers[(numLength - 1) / 2]
}

return median
return median;
}

const sortNumbers = (num1, num2) => {
return num1 - num2
}

export { averageMedian }
export { averageMedian }
Comment thread
raklaptudirm marked this conversation as resolved.
Outdated
6 changes: 6 additions & 0 deletions Maths/test/AverageMedian.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,9 @@ test('should return the median of an array of numbers:', () => {
const medianValue = averageMedian([1, 2, 3, 4, 6, 8])
expect(medianValue).toBe(3.5)
})

test('shouldn`t change source array', () => {
const sourceArray = [3, 2, 1, 4, 6, 8];
averageMedian(sourceArray)
expect(sourceArray).toEqual([3, 2, 1, 4, 6, 8]);
})
Comment thread
raklaptudirm marked this conversation as resolved.
Outdated