fix: correct argument order in fuzzy set union - #15273
Merged
cclauss merged 1 commit intoSep 11, 2026
Merged
Conversation
FuzzySet is declared as (name, left_boundary, peak, right_boundary), but union passed (name, min_left, max_right, avg_peak), so peak and right_boundary were swapped. Swap the last two arguments and update both doctests. Fixes TheAlgorithms#11871 Signed-off-by: Ant19801108 <[email protected]>
Member
|
@priya-sundaram-dev please evaluate this as a fix for #11871. If it is not the right fix then please create a pull request that closes this pull request and 11871. |
Contributor
|
Confirmed — this is the right fix for #11871. ✅ The dataclass is declared Verified on the PR head:
Diff is minimal and scoped to the bug. LGTM — this closes #11871. |
cclauss
approved these changes
Sep 11, 2026
cclauss
left a comment
Member
There was a problem hiding this comment.
Awesome work. Thanks to both of you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11871 — the fuzzy
unionmethod passed constructor arguments in the wrong order.FuzzySetis declared as(name, left_boundary, peak, right_boundary), butunioncalledFuzzySet(name, min_left, max_right, avg_peak), sopeakandright_boundarywere swapped. This swaps the last two arguments and corrects both doctests.Type of change
Checklist
python -m doctest fuzzy_logic/fuzzy_operations.pypasses (22 doctests, 0 failures).