Update upstream #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…uejs#749) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Haoqun Jiang <[email protected]>
# Conflicts: # index.ts # pnpm-lock.yaml
There was a problem hiding this comment.
Pull Request Overview
This pull request rebrands the project to create-vue-enhanced and introduces several new configuration options including Tailwind CSS, Commitlint, experimental features (Oxlint and Rolldown Vite), as well as updates to workflows and documentation.
- Rebranding updates in README, package.json, and repository URLs
- New feature flags and experimental feature prompts added in index.ts (supporting oxlint and rolldown-vite)
- Version bumps and dependency updates across configuration templates and CI workflows
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| template/config//.json files | Updated dependency versions across various configurations |
| rolldown.config.ts | Updated unused parameter handling |
| package.json | Updated engine requirement, dependency versions, and rebranding metadata |
| locales/*.json | Updated messages for experimental features and branding |
| index.ts | Introduced experimental feature options and logic for oxlint and rolldown-vite |
| test/renderEslint.spec.ts | Updated test expectations for ESLint plugin importer changes |
| LICENSE | Updated repository URL for Clack dependency |
| .github/workflows/ci.yml | Updated Node versions for compatibility with new engine requirement |
Comments suppressed due to low confidence (2)
package.json:17
- The Node engine requirement was updated from v18 to v20; ensure the upgrade process and documentation clearly communicate this breaking change to users.
"node": ">=v20.0.0"
index.ts:507
- Verify that the combined condition for rendering ESLint config meets the intended behavior, ensuring that the ESLint configuration is rendered when either flag is set.
if (needsEslint || needsOxlint) {
Comment on lines
+407
to
+408
| json.devDependencies.vite = 'npm:rolldown-vite@latest' | ||
| fs.writeFileSync(path.resolve(root, 'package.json'), JSON.stringify(json, null, 2)) |
There was a problem hiding this comment.
Consider adding a safeguard check to ensure that 'vite' exists in devDependencies before attempting to replace it, to improve error resilience.
Suggested change
| json.devDependencies.vite = 'npm:rolldown-vite@latest' | |
| fs.writeFileSync(path.resolve(root, 'package.json'), JSON.stringify(json, null, 2)) | |
| if (json.devDependencies && json.devDependencies.vite) { | |
| json.devDependencies.vite = 'npm:rolldown-vite@latest' | |
| fs.writeFileSync(path.resolve(root, 'package.json'), JSON.stringify(json, null, 2)) | |
| } else { | |
| console.warn("'vite' is not found in devDependencies. Skipping replacement.") | |
| } |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the
create-vueproject, now rebranded ascreate-vue-enhanced. The changes include rebranding, adding new configuration options for Tailwind CSS and Commitlint, and updating workflows and documentation to reflect these updates.Rebranding and Repository Updates:
create-vuetocreate-vue-enhanced, with updates toREADME.md,package.json, and repository URLs to reflect the new branding. ([[1]](https://github.com/TheNacken/create-vue/pull/3/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L1-R16),[[2]](https://github.com/TheNacken/create-vue/pull/3/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L2-R4),[[3]](https://github.com/TheNacken/create-vue/pull/3/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L40-R48))New Features and Options:
index.ts, language files, and configuration templates. ([[1]](https://github.com/TheNacken/create-vue/pull/3/files#diff-dcdc3e0b3362edb8fec2a51d3fa51f8fb8af8f70247e06d9887fa934834c9122R42-R44),[[2]](https://github.com/TheNacken/create-vue/pull/3/files#diff-dcdc3e0b3362edb8fec2a51d3fa51f8fb8af8f70247e06d9887fa934834c9122R83-R90),[[3]](https://github.com/TheNacken/create-vue/pull/3/files#diff-dcdc3e0b3362edb8fec2a51d3fa51f8fb8af8f70247e06d9887fa934834c9122R210-R213),[[4]](https://github.com/TheNacken/create-vue/pull/3/files#diff-dcdc3e0b3362edb8fec2a51d3fa51f8fb8af8f70247e06d9887fa934834c9122R372-R373),[[5]](https://github.com/TheNacken/create-vue/pull/3/files#diff-dcdc3e0b3362edb8fec2a51d3fa51f8fb8af8f70247e06d9887fa934834c9122R533-R540),[[6]](https://github.com/TheNacken/create-vue/pull/3/files#diff-dcdc3e0b3362edb8fec2a51d3fa51f8fb8af8f70247e06d9887fa934834c9122L524-R562),[[7]](https://github.com/TheNacken/create-vue/pull/3/files#diff-015ce0fec25af6404615a6dcc2bcba0ed110cfaf51a3ef7148142c0e579c5fbcR45-R50),[[8]](https://github.com/TheNacken/create-vue/pull/3/files#diff-825549570aa63033c79f4edb076fba4598c8da2f5611e2d6eb0d7d3a7b4394afR45-R50),[[9]](https://github.com/TheNacken/create-vue/pull/3/files#diff-cf01a4d00c9b953dfb121e93ab3afe5dd64edcf2f6595254f9cf66dba8b38690R45-R50),[[10]](https://github.com/TheNacken/create-vue/pull/3/files#diff-5fbf2e8999f66e378efb8d69883f33b1bf539d016aa035fd361144b71cf062cfR45-R50),[[11]](https://github.com/TheNacken/create-vue/pull/3/files#diff-904656d546752356f91344e2ed02bf6287852430377fe182871c4e4f87b5ce95R45-R50),[[12]](https://github.com/TheNacken/create-vue/pull/3/files#diff-a3d4b2860ef6f66b9ebd66bdd5b5a1e48c15153700f07fefa3c07138df006d90R1),[[13]](https://github.com/TheNacken/create-vue/pull/3/files#diff-d0299257aa169012bb84c4267cca675c7ca9ff663a2250f91b4c570fa0fbcf83R1-R6),[[14]](https://github.com/TheNacken/create-vue/pull/3/files#diff-d1ea482d222051e39cc418853bccc3d2483ac69053d03a66fb6ba5625415c9aeR1-R6),[[15]](https://github.com/TheNacken/create-vue/pull/3/files#diff-0f78529f472a5f66c736ef1a3fd22de924b4fb7c24cfdebaadfd81175daabc94R1),[[16]](https://github.com/TheNacken/create-vue/pull/3/files#diff-443e33d1fa3752126cb12b22c4e95d473dd3307f2da16dc4d70bd5e1ca327d0cR1-R13),[[17]](https://github.com/TheNacken/create-vue/pull/3/files#diff-54a044bea79c8d428ae4f7ae7ba66d445805ffb770e98fe50dcd6a4c2798fcc3R1-R12),[[18]](https://github.com/TheNacken/create-vue/pull/3/files#diff-97df355f2ac460555af5a88be433a9f74841863bd0d7da3a6b00f46c201f3312R1-R15),[[19]](https://github.com/TheNacken/create-vue/pull/3/files#diff-486e5761c3738b128744145b908510489f5062ad100e2958ee25c54020e0199fR1-R12),[[20]](https://github.com/TheNacken/create-vue/pull/3/files#diff-09b1e233e9562dee453ac53d02b09131c6e1442633f3c629f2d92d37e9a72bceR1-R7),[[21]](https://github.com/TheNacken/create-vue/pull/3/files#diff-a6389450c15a40f158a4d710686ebd53ac99a6b8c36a11c2d7f68638d4e8ccadR35-R36))Workflow Updates:
.github/workflows/publish.ymlto trigger on pushes to themainbranch instead of tags, and to ignore changes toREADME.md. ([.github/workflows/publish.ymlL5-R8](https://github.com/TheNacken/create-vue/pull/3/files#diff-551d1fcf87f78cc3bc18a7b332a4dc5d8773a512062df881c5aba28a6f5c48d7L5-R8))Documentation Updates:
README.mdto reflect the new project name and the enhanced features, including updated commands for creating projects and new options available. ([[1]](https://github.com/TheNacken/create-vue/pull/3/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L1-R16),[[2]](https://github.com/TheNacken/create-vue/pull/3/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L23-R37))These changes collectively improve the usability of the project by introducing new features, enhancing documentation, and aligning the repository with the updated branding.