This repository was archived by the owner on Aug 31, 2023. It is now read-only.
Merged
Conversation
TheZ3ro
approved these changes
May 25, 2017
Owner
TheZ3ro
left a comment
There was a problem hiding this comment.
Wow, nice work! This will also need a tool upgrade I think, lots of tools here are outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a stab at doing some refactoring and it appears to work fine. I replaced the
shell=Truecalls (they are not needed with this, perhaps on Windows they where) and added acallwrapper to print what is currently running.I made all the
callcalls use arrays, which gets around the quoting issues that you experience if you useshell=trueand manually concatenate strings together.I got rid of the hard-coded
*************headers for each stage and added a function that deals with them dynamically. I also ran an auto-formatter on the code to make it more pythonic, hence the horrible diff. Sorry!Grab a copy of the script from my branch here: https://github.com/orf/apk2java-linux/blob/patch-1/apk2java.py
Give it a test and if it's OK then merge 👍 feel free to ask me any questions
~~Currently this doesn't work with APK's that have a space in them. No big deal I guess, but I figured I would try and refactor the code to use
subprocess.callproperly rather than just concating strings everywhere.~~~Edit: also, thanks for this script, it's pretty damn good!