Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dudoslav
Copy link
Contributor

@dudoslav dudoslav commented May 1, 2024

Enable python 3.12 for this repo


[sc-37726]

@dudoslav dudoslav requested review from ihnorton and kounelisagis May 1, 2024 15:01
@johnkerl
Copy link
Contributor

johnkerl commented May 1, 2024

See also #1865

@kounelisagis
Copy link
Member

kounelisagis commented May 8, 2024

Reasons why tests were failing:

Copy link
Member

@kounelisagis kounelisagis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe wait for another approval to check my changes.

@dudoslav
Copy link
Contributor Author

dudoslav commented May 8, 2024

Please include pytest outputs for 3.12 executions

Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about fully_trusted; otherwise LGTM. Thanks @kounelisagis @dudoslav!

@dudoslav dudoslav merged commit f230b9c into dev May 9, 2024
@dudoslav dudoslav deleted the db/python312 branch May 9, 2024 08:42
@kounelisagis
Copy link
Member

kounelisagis commented May 9, 2024

Please include pytest outputs for 3.12 executions

Python 3.12.3 | packaged by conda-forge | (main, Apr 15 2024, 18:20:11) [MSC v.1938 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import tiledb
>>> tiledb.version()
(0, 28, 1, 'dev10')
>>> tiledb.libtiledb.version()
(2, 20, 1)

Tests run successfully.

Comment on lines +281 to +282
or isinstance(variable.args[0], ast.Constant)
or isinstance(variable.args[0], ast.Constant)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these redundant?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh wow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants