Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix #38#42

Merged
calvintam236 merged 8 commits intomasterfrom
hotfix/return-this
May 15, 2022
Merged

Fix #38#42
calvintam236 merged 8 commits intomasterfrom
hotfix/return-this

Conversation

@calvintam236
Copy link
Member

No description provided.

@calvintam236 calvintam236 added the bug Something isn't working label Mar 7, 2022
@calvintam236
Copy link
Member Author

Blocked by #18

@calvintam236 calvintam236 changed the title fix: partial fix #38 Fix #38 Mar 7, 2022
@calvintam236 calvintam236 linked an issue Mar 7, 2022 that may be closed by this pull request
@calvintam236 calvintam236 added this to the v2.1.0 milestone Mar 8, 2022
@calvintam236
Copy link
Member Author

calvintam236 commented May 15, 2022

@WieFel looks like #58 fixed the issues.. probably due to color was changed before another test case.

@calvintam236 calvintam236 marked this pull request as ready for review May 15, 2022 15:02
@calvintam236 calvintam236 requested a review from WieFel May 15, 2022 15:02
@calvintam236 calvintam236 changed the title Fix #38 Most setters should update internal color value and return this May 15, 2022
@calvintam236 calvintam236 changed the title Most setters should update internal color value and return this Fix #38 May 15, 2022
@calvintam236 calvintam236 merged commit fe902d6 into master May 15, 2022
@calvintam236 calvintam236 deleted the hotfix/return-this branch May 15, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Most setters should update internal color value and return this

2 participants