Use xxh128 hash algorithm for PHP ^8.1 - #44
Merged
Toflar merged 1 commit intoDec 20, 2022
Conversation
alexander-schranz
force-pushed
the
feature/use-xxh128-for-php-8.1
branch
from
December 19, 2022 23:43
f507220 to
d1cf608
Compare
alexander-schranz
marked this pull request as ready for review
December 19, 2022 23:44
Toflar
approved these changes
Dec 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symfony Store did also change to xxh128 so we can do the same: symfony/symfony#47094
As we support still php versions lower 8.1 we will fallback to sha256.