Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@devanshu052000
Copy link
Collaborator

@devanshu052000 devanshu052000 commented Dec 11, 2025

Context

App history was not working because BullMQ isn’t yet configured in all environments, so history jobs never processed.

What this PR does

Temporarily disables app history.

Impact

App history capture and UI entry point are disabled; no history will be collected or shown.

Follow-ups (post-setup)

  • Finish BullMQ configuration in all environments.
  • Re-enable queueHistoryCapture and the sidebar icon once the setup is validated end-to-end.

@devanshu052000 devanshu052000 self-assigned this Dec 11, 2025
@devanshu052000 devanshu052000 added create-ce-review-app create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile labels Dec 11, 2025
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

Enterprise Edition (LTS):
Deployment: https://tooljet-ee-pr-14759.onrender.com
Dashboard: https://dashboard.render.com/web/srv-d4t6db1r0fns73d6ck30

@bito-code-review
Copy link

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to fix an issue with app history not working on cloud by completely disabling the app history feature. Rather than addressing the root cause, the implementation has been commented out both on the backend (the history capture queue logic) and frontend (the UI icon to access history).

Key changes:

  • Backend: Commented out the entire queueHistoryCapture method implementation, effectively disabling all app history tracking
  • Frontend: Commented out the AppHistoryIcon component in the sidebar, removing user access to the history feature
  • Code formatting: Minor formatting changes to compress multi-line statements to single lines

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
server/src/modules/app-history/util.service.ts Disabled the entire queueHistoryCapture method by commenting out its implementation, preventing any app history from being captured; includes minor formatting changes
frontend/src/AppBuilder/LeftSidebar/LeftSidebar.jsx Commented out the AppHistoryIcon component to hide the history feature from the UI sidebar

Critical Concerns:

  • This is a workaround that removes functionality rather than fixing the underlying issue
  • The backend method is called from multiple services (components, events, pages, queries, versions) but now does nothing
  • The frontend still has code to display app history (line 123) but no way to trigger it, creating unreachable code
  • No documentation explaining why this is disabled or plans to restore functionality
  • Large blocks of commented code remain instead of being removed, reducing maintainability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bito-code-review
Copy link

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

@devanshu052000 devanshu052000 changed the title Fix: App history not working on cloud Fix: Revert app history feature Dec 11, 2025
@bito-code-review
Copy link

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at [email protected].

@johnsoncherian johnsoncherian merged commit d3ea29f into lts-3.16 Dec 11, 2025
59 checks passed
@johnsoncherian johnsoncherian deleted the fix/app-history branch December 11, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants