-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Fix: Revert app history feature #14759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Community Edition:- |
|
Enterprise Edition (LTS): |
|
Bito Automatic Review Skipped - Branch Excluded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to fix an issue with app history not working on cloud by completely disabling the app history feature. Rather than addressing the root cause, the implementation has been commented out both on the backend (the history capture queue logic) and frontend (the UI icon to access history).
Key changes:
- Backend: Commented out the entire
queueHistoryCapturemethod implementation, effectively disabling all app history tracking - Frontend: Commented out the
AppHistoryIconcomponent in the sidebar, removing user access to the history feature - Code formatting: Minor formatting changes to compress multi-line statements to single lines
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
server/src/modules/app-history/util.service.ts |
Disabled the entire queueHistoryCapture method by commenting out its implementation, preventing any app history from being captured; includes minor formatting changes |
frontend/src/AppBuilder/LeftSidebar/LeftSidebar.jsx |
Commented out the AppHistoryIcon component to hide the history feature from the UI sidebar |
Critical Concerns:
- This is a workaround that removes functionality rather than fixing the underlying issue
- The backend method is called from multiple services (components, events, pages, queries, versions) but now does nothing
- The frontend still has code to display app history (line 123) but no way to trigger it, creating unreachable code
- No documentation explaining why this is disabled or plans to restore functionality
- Large blocks of commented code remain instead of being removed, reducing maintainability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Bito Automatic Review Skipped - Branch Excluded |
|
Bito Automatic Review Skipped - Branch Excluded |
Context
App history was not working because BullMQ isn’t yet configured in all environments, so history jobs never processed.
What this PR does
Temporarily disables app history.
Impact
App history capture and UI entry point are disabled; no history will be collected or shown.
Follow-ups (post-setup)