fix(data): index foreign-key back-references and per-manifest failed …#97
Merged
Conversation
…state PostgreSQL doesn't auto-index the referencing side of a foreign key, so deleting a metadata row forced the scheduler's cleanup DELETE to scan work_queue, dead_letter and metadata to satisfy the ON DELETE RESTRICT checks, which degraded to O(table) on a large database. Add partial indexes on metadata.parent_id, work_queue.metadata_id and dead_letter.retry_metadata_id. Also add a partial (manifest_id, start_time) index on failed metadata so the dispatch loop's per-manifest FailedCount stays bounded to failed rows instead of scanning the manifest's whole terminal history. Postgres migration 036, SQLite 004.
|
This PR is included in version 1.41.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…state
PostgreSQL doesn't auto-index the referencing side of a foreign key, so deleting a metadata row forced the scheduler's cleanup DELETE to scan work_queue, dead_letter and metadata to satisfy the ON DELETE RESTRICT checks, which degraded to O(table) on a large database. Add partial indexes on metadata.parent_id, work_queue.metadata_id and dead_letter.retry_metadata_id.
Also add a partial (manifest_id, start_time) index on failed metadata so the dispatch loop's per-manifest FailedCount stays bounded to failed rows instead of scanning the manifest's whole terminal history. Postgres migration 036, SQLite 004.