-
Notifications
You must be signed in to change notification settings - Fork 0
Implement do #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Implement do #42
Conversation
Pre-emptive note here: in #40 the To avoid the solver accidentally picking up these constant parameters as values that should vary we could either:
|
Ooh, we could just remove the node that the do is setting the value of and do this move without needing to add a new node. This feels very neat so I'll do this |
rtol=1e-1, | ||
) | ||
|
||
assert np.isclose( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also check here that parameters is empty
Implement a do algorithms that takes a graph and replaces a node with a constant
ParameterNode
and removes any edges going into that node.As expectation and other algorithms already only iterate over ancestors of output nodes, there's no need to trim the graph further when applying a do.
Builds on #39, so is currently set to merge into that branch.