Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@crypto-vincent
Copy link
Contributor

@crypto-vincent crypto-vincent commented Jul 7, 2023

There seems to be a bug in a very specific case:

  • If the credix depository has NO OVERFLOW
  • Aka if the depository has too much deposit compared to its target
  • then the precision loss maths fails to redirect the precision loss from the profits to the overflow
  • This means that 1 native unit remains untransfered and it triggers the safety assertions

Notes:

  • when credix is overweight (which is most of the time since its an illiquid protocol) then this problem does not exist.
  • The rebalancing worked as of today (07/07/23) since credix was overweight today, so no emergency
  • I added a test that reproduce this issue in the rust integration tests

@crypto-vincent crypto-vincent self-assigned this Jul 7, 2023
@crypto-vincent crypto-vincent merged commit 999edc5 into main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants