Change default SPECI parsing - #2819
Merged
Merged
Conversation
Per discussion in Unidata#2759, the option to parse SPECI observations was made into a user parameter and is off by default.
dopplershift
reviewed
Dec 7, 2022
dopplershift
approved these changes
Dec 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion in #2759, the option to parse SPECI observations was made into a user parameter and is off by default.
This was the most reasonable approach to extracting METAR data that I could think of. Sometimes GEMPAK will also have the standard METAR data as text. If I parsed that, the timestamps would be more precise. However, as @sgdecker had alluded to, users do not want to have to dig for the top of the hour observations. You do have AWOS that do standard reports every 20 minutes, but those are going to be less susceptible to the GEMPAK file time bin issue than SPECI reports. Unless there is a strong desire to also have the ability to parse standard observation text, then this should work for most people.
Checklist