Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Wet bulb potential temperature - #2952

Merged
dopplershift merged 3 commits into
Unidata:mainfrom
sec147:wbpt
Nov 30, 2023
Merged

Wet bulb potential temperature#2952
dopplershift merged 3 commits into
Unidata:mainfrom
sec147:wbpt

Conversation

@sec147

@sec147 sec147 commented Mar 11, 2023

Copy link
Copy Markdown
Contributor

Description Of Changes

Add function to calculate wet bulb potential temperature to calcs, with associated docstring and (minimal) test.
This is my first ever pull request - I've read all the docs and tested and think it's ok. Would value feedback.

Checklist

  • Tests added
  • Fully documented

@sec147
sec147 requested a review from a team as a code owner March 11, 2023 18:01
@sec147
sec147 requested review from dcamron and removed request for a team March 11, 2023 18:01
@CLAassistant

CLAassistant commented Mar 11, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@sec147 sec147 changed the title Wbpt Wet bulb potential temperature Mar 11, 2023

@dopplershift dopplershift left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! At first I was concerned this would be fundamentally different from the Bolton 1980 stuff we've used before, but I see this actually explicitly relies on it--that's great! Just a few minor tweaks to improve the docs (especially for the web) and to improve the implementation a bit. Otherwise, it looks good!

Comment thread src/metpy/calc/thermo.py
Comment thread src/metpy/calc/thermo.py Outdated
Comment thread src/metpy/calc/thermo.py Outdated
Comment thread src/metpy/calc/thermo.py Outdated
@dopplershift dopplershift added Type: Feature New functionality Area: Calc Pertains to calculations labels Mar 24, 2023
@dopplershift dopplershift added this to the April 2023 milestone Mar 24, 2023
@dopplershift dopplershift modified the milestones: 1.5.0, September 2023 May 3, 2023
@kgoebber

Copy link
Copy Markdown
Collaborator

@sec147 just pinging to see if you have any cycles to address the comments on this PR and ability to rebase on main and address any conflicts that might have crept in while this was being worked on. If not, just let us know and we can move it forward from what you have submitted up to this point.

@kgoebber
kgoebber force-pushed the wbpt branch 2 times, most recently from 45a0c72 to cdb74b6 Compare October 5, 2023 22:35
sec147 and others added 2 commits November 14, 2023 17:07
…lent potential

temperature function and formula given in DaviesJones2009
@dopplershift

Copy link
Copy Markdown
Member

Ok, git surgery taken care of. I think this is good to go, but I added a commit renaming wetbulb to wet_bulb for consistency with the existing wet_bulb_temperature.

Need a review from @dcamron since I committed here.

@kgoebber
kgoebber self-requested a review November 30, 2023 16:23
@dopplershift
dopplershift merged commit cd7635d into Unidata:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Calc Pertains to calculations Type: Feature New functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants