馃悰馃敤 on zero-size array to reduction operation in lfc when there is no el - #3796
Merged
Merged
Conversation
|
|
dopplershift
approved these changes
Apr 21, 2025
dopplershift
left a comment
Member
There was a problem hiding this comment.
Thinking over the logic, not to mention your graphics above, I agree that this is the correct solution. (Contrary to my comment in the issue.)
Member
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Size check to insure a non-zero sized array prior to calling
np.min(el_pressure) > this_lcl[0]which was throwing aValueError("zero-size array to reduction operation minimum which has no identity").As a quick example, here is the result of
MUCAPEprior to the fix, where the error was caught andnanvalues were inserted.whiterepresents those missing values.Post fix; the calculation is using the
LCLas theLFCand this is the result.Checklist