Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add sarif results minimization #490 #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 13, 2022
Merged

Add sarif results minimization #490 #498

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e396f0
Add sarif results minimization (#490)
mmvpm Jul 11, 2022
d8f34a6
Add unit tests
mmvpm Jul 12, 2022
1a08be9
Fix typos in comments
mmvpm Jul 12, 2022
587cf11
Fix after review
mmvpm Jul 12, 2022
c3c2b03
Fix after review
mmvpm Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add unit tests
  • Loading branch information
@mmvpm
mmvpm committed Jul 13, 2022
commit d8f34a644569f48d7ee210380c48e3e05b1fcf4b
53 changes: 53 additions & 0 deletions utbot-framework/src/test/kotlin/org/utbot/sarif/SarifReportTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,59 @@ class SarifReportTest {
assert(codeFlowPhysicalLocations[0].region.startColumn == 5)
}

@Test
fun testMinimizationRemovesDuplicates() {
mockUtMethodNames()

val mockUtExecution = Mockito.mock(UtExecution::class.java, Mockito.RETURNS_DEEP_STUBS)
Mockito.`when`(mockUtExecution.result).thenReturn(UtImplicitlyThrownException(NullPointerException(), false))

val testCases = listOf(
UtTestCase(mockUtMethod, listOf(mockUtExecution)),
UtTestCase(mockUtMethod, listOf(mockUtExecution)) // duplicate
)

val report = SarifReport(
testCases = testCases,
generatedTestsCode = "",
sourceFindingEmpty
).createReport().toSarif()

assert(report.runs.first().results.size == 1) // no duplicates
}

@Test
fun testMinimizationChoosesShortestCodeFlow() {
mockUtMethodNames()

val mockNPE1 = Mockito.mock(NullPointerException::class.java)
val mockNPE2 = Mockito.mock(NullPointerException::class.java)

val mockUtExecution1 = Mockito.mock(UtExecution::class.java, Mockito.RETURNS_DEEP_STUBS)
val mockUtExecution2 = Mockito.mock(UtExecution::class.java, Mockito.RETURNS_DEEP_STUBS)
Mockito.`when`(mockUtExecution1.result).thenReturn(UtImplicitlyThrownException(mockNPE1, false))
Mockito.`when`(mockUtExecution2.result).thenReturn(UtImplicitlyThrownException(mockNPE2, false))

val stackTraceElement1 = StackTraceElement("Main", "main", "Main.java", 3)
val stackTraceElement2 = StackTraceElement("Main", "main", "Main.java", 7)
Mockito.`when`(mockNPE1.stackTrace).thenReturn(arrayOf(stackTraceElement1))
Mockito.`when`(mockNPE2.stackTrace).thenReturn(arrayOf(stackTraceElement1, stackTraceElement2))

val testCases = listOf(
UtTestCase(mockUtMethod, listOf(mockUtExecution1)),
UtTestCase(mockUtMethod, listOf(mockUtExecution2)) // duplicate with longer stack trace
)

val report = SarifReport(
testCases = testCases,
generatedTestsCode = "",
sourceFindingEmpty
).createReport().toSarif()

assert(report.runs.first().results.size == 1) // no duplicates
assert(report.runs.first().results.first().totalCodeFlowLocations() == 1) // with shorter stack trace
}

// internal

private val mockUtMethod = Mockito.mock(UtMethod::class.java, Mockito.RETURNS_DEEP_STUBS)
Expand Down