Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prohibit to set static fields from library classes #697 #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 15, 2022
Merged

Prohibit to set static fields from library classes #697 #699

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d80769c
Prohibit to set static final fields from library classes
sergeypospelov Aug 10, 2022
605d9fb
Do not substitute static fields from library classes with unbounded s…
sergeypospelov Aug 10, 2022
579101d
Fix failed tests in OptionalTest.kt
sergeypospelov Aug 10, 2022
a4235ae
Use TrustedLibraries instead of packagesToProcessConcretely
sergeypospelov Aug 11, 2022
bbcb4a8
Add flag in UtSettings.kt and workaround reason
sergeypospelov Aug 12, 2022
2d61985
Fix CE
sergeypospelov Aug 12, 2022
db659ce
Apply review comments
sergeypospelov Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply review comments
  • Loading branch information
@sergeypospelov
sergeypospelov committed Aug 15, 2022
commit db659ce57c897e34d5bb9bc0125a40d74d09bc43
11 changes: 9 additions & 2 deletions utbot-framework/src/main/kotlin/org/utbot/engine/Traverser.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1790,11 +1790,18 @@ class Traverser(
return createdField
}

/**
* For now the field is `meaningful` if it is safe to set, that is, it is not an internal system field nor a
* synthetic field. This filter is needed to prohibit changing internal fields, which can break up our own
* code and which are useless for the user.
*
* @return `true` if the field is meaningful, `false` otherwise.
*/
private fun isStaticFieldMeaningful(field: SootField) =
!Modifier.isSynthetic(field.modifiers) &&
// we don't want to set fields from library classes
workaround(IGNORE_STATICS_FROM_TRUSTED_LIBRARIES) {
!ignoreStaticsFromTrustedLibraries || !field.declaringClass.isFromTrustedLibrary()
!workaround(IGNORE_STATICS_FROM_TRUSTED_LIBRARIES) {
ignoreStaticsFromTrustedLibraries && field.declaringClass.isFromTrustedLibrary()
}

/**
Expand Down