support sets

UnitTestBot · AbdullinAM · Jun 20, 2022 · Jun 20, 2022 · Jun 22, 2022 · Jun 28, 2022
commit 8963a7ea2211825717eb388901757998e66bc6dd
diff --git a/utbot-framework-api/src/main/kotlin/org/utbot/framework/plugin/api/Api.kt b/utbot-framework-api/src/main/kotlin/org/utbot/framework/plugin/api/Api.kt
@@ -504,6 +504,13 @@ data class UtListConstraintModel(
     override val utConstraints: Set<UtConstraint> = emptySet()
 ) : UtElementContainerConstraintModel(variable, length, elements, utConstraints)
 
+data class UtSetConstraintModel(
+    override val variable: UtConstraintVariable,
+    override val length: UtModel,
+    override val elements: Map<UtModel, UtModel>,
+    override val utConstraints: Set<UtConstraint> = emptySet()
+) : UtElementContainerConstraintModel(variable, length, elements, utConstraints)
+
 /**
  * Model for complex objects with assemble instructions.
  *

diff --git a/utbot-framework/src/main/kotlin/org/utbot/engine/constraints/ConstraintResolver.kt b/utbot-framework/src/main/kotlin/org/utbot/engine/constraints/ConstraintResolver.kt
@@ -287,7 +287,8 @@ class ConstraintResolver(
         aliases: Set<UtConstraintVariable>
     ): UtModel = when (concrete.value) {
         is ListWrapper -> buildListModel(concrete.value, variable, atoms, aliases)
-        else -> TODO()
+        is SetWrapper -> buildSetModel(concrete.value, variable, atoms, aliases)
+        else -> buildObjectModel(variable, atoms, aliases)
     }
 
     private fun buildListModel(
@@ -334,6 +335,36 @@ class ConstraintResolver(
         )
     }
 
+    private fun buildSetModel(
+        concrete: SetWrapper,
+        variable: UtConstraintVariable,
+        atoms: Set<UtConstraint>,
+        aliases: Set<UtConstraintVariable>
+    ): UtModel {
+        val allAliases = aliases + variable
+        val refConstraints = atoms.filter { constraint ->
+            allAliases.any { it in constraint }
+        }.toSet()
+
+        val default = { buildObjectModel(variable, atoms, aliases) }
+        val elementData = atoms
+            .flatten { it is UtConstraintFieldAccess && it.instance == variable && it.fieldId.name == "elementData" }
+            .firstOrNull() as? UtConstraintFieldAccess ?: return default()
+        val storageArray = atoms
+            .flatten { it is UtConstraintFieldAccess && it.instance == elementData && it.fieldId.name == "storage" }
+            .firstOrNull() as? UtConstraintFieldAccess ?: return default()
+        val aliasArrays = aliases.map {
+            UtConstraintFieldAccess(UtConstraintFieldAccess(it, elementData.fieldId), storageArray.fieldId)
+        }.toSet()
+        val array = buildArrayModel(storageArray, atoms, aliasArrays) as UtArrayConstraintModel
+        return UtSetConstraintModel(
+            variable,
+            array.length,
+            array.elements,
+            array.utConstraints + refConstraints
+        )
+    }
+
     private val UtExpression.variable get() = accept(varBuilder)
     private val UtConstraintVariable.expr get() = varBuilder[this]
     private val UtConstraintVariable.addr get() = holder.concreteAddr(expr as UtAddrExpression)

diff --git a/utbot-framework/src/main/kotlin/org/utbot/engine/pc/constraint/UtVarBuilder.kt b/utbot-framework/src/main/kotlin/org/utbot/engine/pc/constraint/UtVarBuilder.kt
@@ -80,13 +80,7 @@ class UtVarBuilder(
             UtConstraintArrayAccess(base, index, objectClassId)
         }
 
-        else -> {
-            System.err.println(base)
-            System.err.println(base.classId)
-            System.err.println(index)
-            System.err.println(index.classId)
-            index
-        }
+        else -> index
     }
 
     override fun visit(expr: UtMkArrayExpression): UtConstraintVariable {

diff --git a/utbot-framework/src/main/kotlin/org/utbot/framework/synthesis/Resolver.kt b/utbot-framework/src/main/kotlin/org/utbot/framework/synthesis/Resolver.kt
@@ -24,6 +24,7 @@ class Resolver(
             is ReferenceToUnit -> resolve(synthesisUnitContext[unit.reference])
             is ArrayUnit -> unitToModel.getOrPut(unit) { resolveArray(unit) }
             is ListUnit -> unitToModel.getOrPut(unit) { resolveList(unit) }
+            is SetUnit -> unitToModel.getOrPut(unit) { resolveSet(unit) }
         }
 
     private fun resolveMethodUnit(unit: MethodUnit): UtModel =
@@ -77,10 +78,12 @@ class Resolver(
         return model
     }
 
-    private fun resolveList(unit: ListUnit): UtModel {
-        val elements = unit.elements.associate {
-            resolve(synthesisUnitContext[it.first]) to resolve(synthesisUnitContext[it.second])
-        }
+    private fun resolveCollection(
+        unit: ElementContainingUnit,
+        constructorId: ConstructorId,
+        modificationId: MethodId
+    ): UtModel {
+        val elements = unit.elements.map { resolve(synthesisUnitContext[it.second]) }
 
         val instantiationChain = mutableListOf<UtStatementModel>()
         val modificationChain = mutableListOf<UtStatementModel>()
@@ -94,20 +97,24 @@ class Resolver(
         )
 
         instantiationChain.add(
-            UtExecutableCallModel(model, unit.constructorId, listOf(), model)
+            UtExecutableCallModel(model, constructorId, listOf(), model)
         )
 
-        for ((_, value) in elements) {
+        for (value in elements) {
             modificationChain.add(
                 UtExecutableCallModel(
-                    model, unit.addId, listOf(value),
+                    model, modificationId, listOf(value),
                 )
             )
         }
 
         return model
     }
 
+    private fun resolveList(unit: ListUnit): UtModel = resolveCollection(unit, unit.constructorId, unit.addId)
+
+    private fun resolveSet(unit: SetUnit): UtModel = resolveCollection(unit, unit.constructorId, unit.addId)
+
     private fun resolveArray(unit: ArrayUnit): UtModel {
         val lengthModel = resolve(synthesisUnitContext[unit.length]) as UtPrimitiveModel
         val elements = unit.elements.associate {

diff --git a/utbot-framework/src/main/kotlin/org/utbot/framework/synthesis/SynthesisMethodContext.kt b/utbot-framework/src/main/kotlin/org/utbot/framework/synthesis/SynthesisMethodContext.kt
@@ -141,8 +141,7 @@ class SynthesisMethodContext(
         }
 
         is ListUnit -> synthesizeConstructorInvoke(unit.constructorId, listOf())
-
-        else -> TODO()
+        is SetUnit -> synthesizeConstructorInvoke(unit.constructorId, listOf())
     }
 
     private fun synthesizeSetExpr(
@@ -158,7 +157,7 @@ class SynthesisMethodContext(
 
         is ListUnit -> synthesizeVirtualInvoke(unit.addId, listOf(unitLocal, value))
 
-        else -> TODO()
+        is SetUnit -> synthesizeVirtualInvoke(unit.addId, listOf(unitLocal, value))
     }
 
     private fun synthesizeVirtualInvoke(method: MethodId, parameterLocals: List<JimpleLocal>): JimpleLocal {

diff --git a/utbot-framework/src/main/kotlin/org/utbot/framework/synthesis/SynthesisUnit.kt b/utbot-framework/src/main/kotlin/org/utbot/framework/synthesis/SynthesisUnit.kt
@@ -41,6 +41,17 @@ data class ListUnit(
     }
 }
 
+data class SetUnit(
+    override val classId: ClassId,
+    override val elements: List<Pair<UtModel, UtModel>>,
+    override val length: UtModel
+) : ElementContainingUnit(classId, elements, length) {
+    val constructorId get() = classId.allConstructors.first { it.parameters.isEmpty() }
+    val addId get() = classId.allMethods.first {
+        it.name == "add" && it.parameters == listOf(objectClassId)
+    }
+}
+
 data class NullUnit(
     override val classId: ClassId
 ) : SynthesisUnit()

diff --git a/utbot-framework/src/main/kotlin/org/utbot/framework/synthesis/Synthesizer.kt b/utbot-framework/src/main/kotlin/org/utbot/framework/synthesis/Synthesizer.kt
@@ -95,6 +95,12 @@ class SynthesisUnitContext(
                     this.length
                 )
 
+                is UtSetConstraintModel -> SetUnit(
+                    this.classId,
+                    this.elements.toList(),
+                    this.length
+                )
+
                 is UtReferenceToConstraintModel -> ReferenceToUnit(this.classId, this.reference)
                 else -> error("Only UtSynthesisModel supported")
             }

diff --git a/...framework/synthesis/postcondition/constructors/ConstraintBasedPostConditionConstructor.kt b/...framework/synthesis/postcondition/constructors/ConstraintBasedPostConditionConstructor.kt
@@ -404,26 +404,34 @@ private class UtConstraintBuilder(
     }
 
     override fun visitUtLtConstraint(expr: UtLtConstraint): UtBoolExpression = with(expr) {
-        val lhvVal = lhv.accept(this@UtConstraintBuilder) as PrimitiveValue
-        val rhvVal = rhv.accept(this@UtConstraintBuilder) as PrimitiveValue
+        val lhvVal = lhv.accept(this@UtConstraintBuilder) as? PrimitiveValue
+            ?: error("a")
+        val rhvVal = rhv.accept(this@UtConstraintBuilder) as? PrimitiveValue
+            ?: error("a")
         Lt(lhvVal, rhvVal)
     }
 
     override fun visitUtGtConstraint(expr: UtGtConstraint): UtBoolExpression = with(expr) {
-        val lhvVal = lhv.accept(this@UtConstraintBuilder) as PrimitiveValue
-        val rhvVal = rhv.accept(this@UtConstraintBuilder) as PrimitiveValue
+        val lhvVal = lhv.accept(this@UtConstraintBuilder) as? PrimitiveValue
+            ?: error("a")
+        val rhvVal = rhv.accept(this@UtConstraintBuilder) as? PrimitiveValue
+            ?: error("a")
         Gt(lhvVal, rhvVal)
     }
 
     override fun visitUtLeConstraint(expr: UtLeConstraint): UtBoolExpression = with(expr) {
-        val lhvVal = lhv.accept(this@UtConstraintBuilder) as PrimitiveValue
-        val rhvVal = rhv.accept(this@UtConstraintBuilder) as PrimitiveValue
+        val lhvVal = lhv.accept(this@UtConstraintBuilder) as? PrimitiveValue
+            ?: error("a")
+        val rhvVal = rhv.accept(this@UtConstraintBuilder) as? PrimitiveValue
+            ?: error("a")
         Le(lhvVal, rhvVal)
     }
 
     override fun visitUtGeConstraint(expr: UtGeConstraint): UtBoolExpression = with(expr) {
-        val lhvVal = lhv.accept(this@UtConstraintBuilder) as PrimitiveValue
-        val rhvVal = rhv.accept(this@UtConstraintBuilder) as PrimitiveValue
+        val lhvVal = lhv.accept(this@UtConstraintBuilder) as? PrimitiveValue
+            ?: error("a")
+        val rhvVal = rhv.accept(this@UtConstraintBuilder) as? PrimitiveValue
+            ?: error("a")
         Ge(lhvVal, rhvVal)
     }