Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Switch to kts #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2022
Merged

Switch to kts #976

merged 1 commit into from
Sep 22, 2022

Conversation

denis-fokin
Copy link
Collaborator

Description

Scripts important for multi-language support are switched to kts

Fixes #975

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Automated Testing

CI

Manual Scenario

No specific manual scenario.

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • New tests have been added
  • All tests pass locally with my changes

@denis-fokin denis-fokin force-pushed the denis-fokin/switch-master-to-kts branch from 7f34943 to c7ee388 Compare September 20, 2022 09:14
@denis-fokin denis-fokin marked this pull request as draft September 20, 2022 09:31
@denis-fokin denis-fokin force-pushed the denis-fokin/switch-master-to-kts branch 4 times, most recently from dcd770e to 9a806f5 Compare September 20, 2022 13:57
@denis-fokin denis-fokin marked this pull request as ready for review September 20, 2022 14:14
@denis-fokin denis-fokin enabled auto-merge (squash) September 20, 2022 14:27
dtim
dtim requested changes Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@dtim dtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the Kotlin languageVersion and apiVersion, they may have unintended effects on building process and IDE behavior. Other comments are related to improvements.

@denis-fokin denis-fokin force-pushed the denis-fokin/switch-master-to-kts branch from 792afed to fbc916b Compare September 20, 2022 15:46
@denis-fokin denis-fokin requested a review from dtim September 21, 2022 07:07
mmvpm
mmvpm requested changes Sep 21, 2022
View reviewed changes
@denis-fokin denis-fokin force-pushed the denis-fokin/switch-master-to-kts branch from fbc916b to f411983 Compare September 21, 2022 08:38
@denis-fokin denis-fokin requested a review from mmvpm September 21, 2022 08:47
mmvpm
mmvpm reviewed Sep 21, 2022
View reviewed changes
@denis-fokin denis-fokin force-pushed the denis-fokin/switch-master-to-kts branch 2 times, most recently from b18fded to c07c637 Compare September 21, 2022 12:19
dtim
dtim approved these changes Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@dtim dtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

Markoutte
Markoutte reviewed Sep 21, 2022
View reviewed changes
Markoutte
Markoutte reviewed Sep 21, 2022
View reviewed changes
@denis-fokin denis-fokin force-pushed the denis-fokin/switch-master-to-kts branch from c07c637 to 6ed18f5 Compare September 22, 2022 06:25
@denis-fokin denis-fokin force-pushed the denis-fokin/switch-master-to-kts branch from 6ed18f5 to cd81dd6 Compare September 22, 2022 08:02
@denis-fokin denis-fokin merged commit 6dc08be into main Sep 22, 2022
@denis-fokin denis-fokin deleted the denis-fokin/switch-master-to-kts branch September 22, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Markoutte Markoutte Markoutte left review comments

@dtim dtim dtim approved these changes

@mmvpm mmvpm mmvpm approved these changes

@viktoriia-fomina viktoriia-fomina Awaiting requested review from viktoriia-fomina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to kts
4 participants
@denis-fokin @dtim @Markoutte @mmvpm