Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX: Update sample materials to be URP/HDRP compatible [TBD] #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

FIX: Update sample materials to be URP/HDRP compatible [TBD] #2223

wants to merge 23 commits into from

Conversation

Pauliusd01
Copy link
Collaborator

@Pauliusd01 Pauliusd01 commented Aug 12, 2025 •
edited
Loading

Description

Switches out sample materials to a shadergraph one that is cross compatible between URP/HDRP. One caveat is that if someone wants to use it with the old built in render pipeline they have to install the shadergraph package. Also, this adds a dependency to our own main project as it is a built in render pipeline project.

Note: Shadergraph version added is the one offered by 22.3 which seems to update just fine across our supported editors

Testing status & QA

Import changed samples locally through the package manager, run every scene in player and play mode in a new URP & HDRP project. (22.3, 6.0 & trunk)

Overall Product Risks

  • Complexity: low
  • Halo Effect: low to medium

Comments to reviewers

None yet, TBD

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@Pauliusd01 Pauliusd01 changed the title Update sample materials to be URP/HDRP compatible [TBD] FIX: Update sample materials to be URP/HDRP compatible [TBD] Aug 12, 2025
@codecov-github-com
Copy link

codecov-github-com bot commented Aug 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
Assets/Samples/RebindingUI/Game/Player.cs 0.00% 5 Missing ⚠️ 
@@             Coverage Diff             @@
##           develop    #2223      +/-   ##
===========================================
+ Coverage    68.14%   76.70%   +8.55%     
===========================================
  Files          367      465      +98     
  Lines        53685    87920   +34235     
===========================================
+ Hits         36584    67436   +30852     
- Misses       17101    20484    +3383
Flag Coverage Δ
inputsystem_MacOS_2021.3 5.91% <ø> (?)
inputsystem_MacOS_2021.3_project 78.05% <0.00%> (?)
inputsystem_MacOS_2022.3 5.37% <ø> (?)
inputsystem_MacOS_2022.3_project 74.58% <0.00%> (?)
inputsystem_MacOS_6000.0 5.19% <ø> (?)
inputsystem_MacOS_6000.0_project 76.50% <0.00%> (?)
inputsystem_MacOS_6000.2 5.19% <ø> (?)
inputsystem_MacOS_6000.2_project 76.50% <0.00%> (?)
inputsystem_MacOS_6000.3 5.19% <ø> (?)
inputsystem_MacOS_6000.3_project 76.50% <0.00%> (?)
inputsystem_MacOS_6000.4 5.19% <ø> (?)
inputsystem_MacOS_6000.4_project 76.50% <0.00%> (?)
inputsystem_Ubuntu_2021.3 5.91% <ø> (?)
inputsystem_Ubuntu_2021.3_project 77.96% <0.00%> (?)
inputsystem_Ubuntu_2022.3 5.38% <ø> (?)
inputsystem_Ubuntu_2022.3_project 74.38% <0.00%> (?)
inputsystem_Ubuntu_6000.0 5.19% <ø> (?)
inputsystem_Ubuntu_6000.0_project 76.31% <0.00%> (?)
inputsystem_Ubuntu_6000.2 5.19% <ø> (?)
inputsystem_Ubuntu_6000.2_project 76.31% <0.00%> (?)
inputsystem_Ubuntu_6000.3 5.19% <ø> (?)
inputsystem_Ubuntu_6000.3_project 76.31% <0.00%> (?)
inputsystem_Ubuntu_6000.4 5.19% <ø> (?)
inputsystem_Ubuntu_6000.4_project 76.31% <0.00%> (?)
inputsystem_Windows_2021.3 5.91% <ø> (?)
inputsystem_Windows_2021.3_project 78.19% <0.00%> (?)
inputsystem_Windows_2022.3 5.37% <ø> (?)
inputsystem_Windows_2022.3_project 74.71% <0.00%> (?)
inputsystem_Windows_6000.0 5.19% <ø> (?)
inputsystem_Windows_6000.0_project 76.63% <0.00%> (?)
inputsystem_Windows_6000.2 5.19% <ø> (?)
inputsystem_Windows_6000.2_project 76.63% <0.00%> (?)
inputsystem_Windows_6000.3 5.19% <ø> (?)
inputsystem_Windows_6000.3_project 76.63% <0.00%> (?)
inputsystem_Windows_6000.4 5.19% <ø> (?)
inputsystem_Windows_6000.4_project 76.63% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
Assets/Samples/RebindingUI/Game/Player.cs 0.00% <0.00%> (ø)

... and 98 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pauliusd01
Copy link
Collaborator Author

Getting shader errors on build on 6.3 at the moment

@ekcoh
Copy link
Collaborator

ekcoh commented Aug 18, 2025

Might be that this is still in flight but would recommend updating CHANGELOG to reflect these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pauliusd01 @ekcoh