Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX: out of range exception when pressing undo after creating and editing a new control scheme (ISXB-1607) (DRAFT) #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

FIX: out of range exception when pressing undo after creating and editing a new control scheme (ISXB-1607) (DRAFT) #2237

wants to merge 2 commits into from

Conversation

Darren-Kelly-Unity
Copy link
Collaborator

Description

You could cause multiple null or out of range exceptions if you press undo while editing a control scheme.
This is caused by undo causing the control scheme to be removed while you still have the edit window open.

Now the edit window will stay open until you interact with it, once you interact it will close & no exceptions are thrown anymore.

Testing status & QA

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity:
  • Halo Effect:

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

@Darren-Kelly-Unity
Add fix for multiple null refs caused by a control scheme being delet…
e972f16 
…ed by Undoing the creation of it via ctrl+z.
@codecov-github-com
Copy link

codecov-github-com bot commented Sep 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 8.82353% with 31 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...or/UITKAssetEditor/Views/InputActionsEditorView.cs 10.71% 25 Missing ⚠️
.../UITKAssetEditor/Commands/ControlSchemeCommands.cs 0.00% 6 Missing ⚠️ 
@@             Coverage Diff             @@
##           develop    #2237      +/-   ##
===========================================
- Coverage    68.14%   68.12%   -0.03%     
===========================================
  Files          367      367              
  Lines        53685    53713      +28     
===========================================
+ Hits         36585    36592       +7     
- Misses       17100    17121      +21
Flag Coverage Δ
linux_2021.3_pkg 5.47% <ø> (ø)
linux_2021.3_project 70.40% <ø> (ø)
linux_2022.3_pkg 5.24% <0.00%> (-0.01%) ⬇️
linux_2022.3_project 65.21% <0.00%> (-0.04%) ⬇️
linux_6000.0_pkg 5.25% <0.00%> (-0.01%) ⬇️
linux_6000.0_project 68.02% <8.82%> (-0.05%) ⬇️
linux_6000.2_pkg 5.25% <0.00%> (-0.01%) ⬇️
linux_6000.2_project 68.02% <8.82%> (-0.04%) ⬇️
linux_trunk_pkg 5.25% <0.00%> (-0.01%) ⬇️
linux_trunk_project 68.02% <8.82%> (-0.03%) ⬇️
mac_2021.3_pkg 5.46% <ø> (ø)
mac_2021.3_project 70.41% <ø> (ø)
mac_2022.3_pkg 5.23% <0.00%> (-0.01%) ⬇️
mac_2022.3_project 65.24% <0.00%> (-0.04%) ⬇️
mac_6000.0_pkg 5.24% <0.00%> (-0.01%) ⬇️
mac_6000.0_project 68.04% <8.82%> (-0.04%) ⬇️
mac_6000.2_pkg 5.24% <0.00%> (-0.01%) ⬇️
mac_6000.2_project 68.04% <8.82%> (-0.04%) ⬇️
mac_trunk_pkg 5.24% <0.00%> (-0.01%) ⬇️
mac_trunk_project 68.05% <8.82%> (-0.03%) ⬇️
win_2021.3_pkg 5.47% <ø> (ø)
win_2021.3_project 70.49% <ø> (ø)
win_2022.3_pkg 5.24% <0.00%> (-0.01%) ⬇️
win_2022.3_project 65.31% <0.00%> (-0.04%) ⬇️
win_6000.0_pkg 5.25% <0.00%> (-0.01%) ⬇️
win_6000.0_project 68.11% <8.82%> (-0.04%) ⬇️
win_6000.2_pkg 5.25% <0.00%> (-0.01%) ⬇️
win_6000.2_project 68.11% <8.82%> (-0.04%) ⬇️
win_trunk_pkg 5.25% <0.00%> (-0.01%) ⬇️
win_trunk_project 68.11% <8.82%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...Editor/UITKAssetEditor/Views/ControlSchemesView.cs 0.00% <ø> (ø)
.../UITKAssetEditor/Commands/ControlSchemeCommands.cs 76.57% <0.00%> (-2.26%) ⬇️
...or/UITKAssetEditor/Views/InputActionsEditorView.cs 39.66% <10.71%> (-4.57%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Darren-Kelly-Unity